Commit Graph

1549 Commits

Author SHA1 Message Date
Chao Xu
0ba52f642a http2: perform connection health check
After the connection has been idle for a while, periodic pings are sent
over the connection to check its health. Unhealthy connection is closed
and removed from the connection pool.

Fixes golang/go#31643

Change-Id: Idbbc9cb2d3e26c39f84a33e945e482d41cd8583c
GitHub-Last-Rev: 36607fe185
GitHub-Pull-Request: golang/net#55
Reviewed-on: https://go-review.googlesource.com/c/net/+/198040
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
2020-05-20 18:23:14 +00:00
Ian Lance Taylor
59133d7f0d http2: read request in TestTransportBodyLargerThanXXX
Otherwise the server can stop the connection before
clientStream.writeRequestBody has a chance to see if there is any more
data beyond the specified content length.

Tested by adding time.Sleep(time.Millisecond) to chunkReader.Read,
which caused the test to reliably fail before this change,
and reliably pass afterward.

Fixes golang/go#34616

Change-Id: I119bdf01bf916b2ded2c5d293655cba2596c0166
Reviewed-on: https://go-review.googlesource.com/c/net/+/234523
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2020-05-20 00:47:42 +00:00
Richard Miller
d87ec0cfa4 http2: skip OS-dependent tests on Plan 9
In x/net/http2, tests TestServer_RejectsLargeFrames and
TestTransportBodyReadError_* are disabled on Windows because
they fail or flake, being dependent on the behaviour of the
OS network implementation when a connection is closed during
a large write.

The tests fail on Plan 9 for the same reason, so they should be
disabled there as well.

Workaround for golang/go#31260

Fixes golang/go#37321

Change-Id: Ifa1766eaa515c419fc4192126aaf796beefead0a
Reviewed-on: https://go-review.googlesource.com/c/net/+/231877
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
2020-05-19 11:38:04 +00:00
Brad Fitzpatrick
a91f0712d1 icmp, webdav/internal/xml: avoid string(int)
Updates golang/go#32479

Change-Id: Ife0c3a2f10afb676af5f2110a9681216122c8808
Reviewed-on: https://go-review.googlesource.com/c/net/+/233900
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-05-13 18:57:01 +00:00
Tobias Klauser
7e3656a080 ipv4: remove unused const maxHeaderLen
It's unused since CL 162598.

Change-Id: I434dbc9950bb535167c40498ed7c15589db74eaf
Reviewed-on: https://go-review.googlesource.com/c/net/+/232537
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
2020-05-06 14:57:44 +00:00
Filippo Valsorda
1ed23360d1 http2: use ASCII space trimming for parsing Trailer header
Security hardening against HTTP request smuggling recommended by an
external reporter.

Change-Id: I58cba9aa508eca1ae83c3bcf33858b7ba06ca583
Reviewed-on: https://go-review.googlesource.com/c/net/+/231437
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2020-05-05 04:18:28 +00:00
Brad Fitzpatrick
e0ff5e5a1d http2: mark some structs as non-comparable
Reduces binary size by not generating eq algs.

Also, remove the badStringError type that only had one use, and was
just copied from net/http where it's also not used much.

Updates golang/go#38782

Change-Id: I56bddde0bb500109e2c18bb1419e8a920a5bebf9
Reviewed-on: https://go-review.googlesource.com/c/net/+/231119
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-05-01 05:30:45 +00:00
Jia Zhan
ff2c4b7c35 http2: remove unused addConn
`addConn` is dead code that's not used any more.

`addConnLocked` is used when a new connection
needs to be added to the connection pool, and the callers
always manage the lock.

Change-Id: I27d4a402e243a34f8ad707645738953764e05eb3
GitHub-Last-Rev: a213978a85
GitHub-Pull-Request: golang/net#70
Reviewed-on: https://go-review.googlesource.com/c/net/+/230201
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-04-25 23:01:54 +00:00
Ali Farooq
e086a090c8 route: fix spelling of 'represents' in RIBType doc
Change-Id: I5f4ca1a70c90cfa5d8c95ef4d5e8fbfe7f855b1d
GitHub-Last-Rev: 5ada0f59cf
GitHub-Pull-Request: golang/net#69
Reviewed-on: https://go-review.googlesource.com/c/net/+/229224
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-04-21 23:12:49 +00:00
Tobias Klauser
d3edc9973b go.mod: update golang.org/x/sys to fix riscv64 build
Done using:

  go get golang.org/x/sys/unix@latest
  go mod tidy

Updates golang/go#27532

Change-Id: Ibb984f35d969b4f93a492f24560bc957f9dafb65
Reviewed-on: https://go-review.googlesource.com/c/net/+/217359
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-03-24 14:37:07 +00:00
Dmitri Shuralyov
118fecf932 http2/h2demo: update gopher image URL
The URL of the go-programming-language-turns-two_gophers.jpg image
has changed to https://blog.golang.org/2years/2years-gophers.jpg
in CL 223599. Update it here accordingly.

Fixes golang/go#37976

Change-Id: I43d5ee79e0049700bf91a266f0e23b48b3ce53f9
Reviewed-on: https://go-review.googlesource.com/c/net/+/224578
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-03-20 22:07:50 +00:00
Yannic Bonenberger
1c781a1096 gitignore: remove obsolete reference to .hgignore in comment
Change-Id: I24a2e874b55b4a7161bcb7a8919f23af6513ceb2
Reviewed-on: https://go-review.googlesource.com/c/net/+/224317
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-03-20 18:12:08 +00:00
Olivier Poitrey
63522dbf7e http2: reduce allocations of (*clientConnReadLoop).handleReponse
Reduce allocation by using 1 capacity slices out of a single
pre-allocated slice for header values, similarly to how it is done
in textproto.(*Reader).ReadMIMEHeader.

  name                                   old time/op    new time/op    delta
  ClientResponseHeaders/___0_Headers-16    82.3µs ± 7%    76.4µs ± 4%   -7.18%  (p=0.000 n=10+10)
  ClientResponseHeaders/__10_Headers-16     101µs ± 2%      99µs ± 3%   -2.00%  (p=0.016 n=8+10)
  ClientResponseHeaders/_100_Headers-16     213µs ± 2%     202µs ± 4%   -4.96%  (p=0.000 n=9+9)
  ClientResponseHeaders/1000_Headers-16    2.28ms ± 1%    2.15ms ± 2%   -5.58%  (p=0.000 n=8+10)

  name                                   old alloc/op   new alloc/op   delta
  ClientResponseHeaders/___0_Headers-16    4.60kB ± 0%    4.60kB ± 0%     ~     (p=0.201 n=10+10)
  ClientResponseHeaders/__10_Headers-16    9.01kB ± 0%    8.66kB ± 0%   -3.96%  (p=0.000 n=10+10)
  ClientResponseHeaders/_100_Headers-16    54.4kB ± 0%    48.4kB ± 0%  -11.01%  (p=0.000 n=10+10)
  ClientResponseHeaders/1000_Headers-16     702kB ± 0%     595kB ± 0%  -15.28%  (p=0.000 n=10+9)

  name                                   old allocs/op  new allocs/op  delta
  ClientResponseHeaders/___0_Headers-16      57.0 ± 0%      56.0 ± 0%   -1.75%  (p=0.000 n=10+10)
  ClientResponseHeaders/__10_Headers-16       135 ± 0%       123 ± 0%   -8.89%  (p=0.000 n=10+10)
  ClientResponseHeaders/_100_Headers-16       786 ± 0%       679 ± 0%  -13.61%  (p=0.000 n=10+10)
  ClientResponseHeaders/1000_Headers-16     8.14k ± 0%     7.11k ± 0%  -12.65%  (p=0.000 n=10+10)

Fixes golang/go#37853

Change-Id: I0bc6d879293a202a2742a06aca0b6dacfae7fc5f
Reviewed-on: https://go-review.googlesource.com/c/net/+/223783
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-03-19 23:41:17 +00:00
Ian Lance Taylor
244492dfa3 dns/dnsmessage: correct error message to be readable
My earlier change CL 220798 avoided a vet warning for string(i),
but neglected to consider that the vet warning was accurate:
the code was wrong.  The code assumed that string(rune(i)) would
return a readable version of i, but of course it instead returns
the UTF-8 encoding of i.

Updates golang/go#32479

Change-Id: I7410bf9fcd98cbdd193344118ecc81e967a6fb45
Reviewed-on: https://go-review.googlesource.com/c/net/+/221437
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-03-01 02:21:30 +00:00
Volker Dobler
0de0cce016 publicsuffix: update table to latest list from publicsuffix.org
Update the list to revision 7922d7c20e246552be418e8f72e577899fd30d99
(2020-02-18T23:18:19Z).

Change-Id: I634d7a86c28d164474aa266abf69625ef2f4214a
Reviewed-on: https://go-review.googlesource.com/c/net/+/220459
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2020-02-26 12:10:28 +00:00
Ian Lance Taylor
491c5fce72 dns/dnsmessage: avoid string(i) where i has type int
Instead use string(r) where r has type rune.

This is in preparation for a vet warning for string(i).

Updates golang/go#32479

Change-Id: I778323fe01eeac4a1068a350c965039eef84df30
Reviewed-on: https://go-review.googlesource.com/c/net/+/220798
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Akhil Indurti <aindurti@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Toshihiro Shiino <shiino.toshihiro@gmail.com>
2020-02-26 05:17:49 +00:00
Tobias Klauser
5d076fcf07 dns/dnsmessage: remove unused funcs skipText and skipBytes
Change-Id: Ie34e3ec7e83ac98181725238e0010ddb941174c7
Reviewed-on: https://go-review.googlesource.com/c/net/+/220457
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
2020-02-25 22:33:29 +00:00
Tobias Klauser
5a598a2470 http2: remove unused errors
errInvalidHeaderFieldName and errInvalidHeaderFieldValue are unused
since CL 19726.

errInvalidTrailers and errPseudoTrailers were added in CL 18367 but
never used.

Change-Id: I8d4c971f3eaee8b9405e7511645a641c0e513898
Reviewed-on: https://go-review.googlesource.com/c/net/+/220458
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-02-22 12:55:58 +00:00
Dreamacro
078779b8f2 route: fill correctly field
https://github.com/golang/net/blob/master/route/address.go#L37-L56

Wrong order of filling the buffer

Change-Id: Ia598a1f9aaba03f1c0e9890bcf48ed097eb0a1e6
GitHub-Last-Rev: 1ed3d11bbd
GitHub-Pull-Request: golang/net#60
Reviewed-on: https://go-review.googlesource.com/c/net/+/213117
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-02-22 03:33:25 +00:00
Tobias Klauser
4628272708 http2: remove unused stream struct fields
Change-Id: I0ba4465c75dcdb9380a7e0e736acb417e208816b
Reviewed-on: https://go-review.googlesource.com/c/net/+/219857
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
2020-02-19 18:36:55 +00:00
Tobias Klauser
f229aea8fa ipv4, ipv6: remove or move unused err* vars
errNoSuchInterface is only used in ipv4/sys_asmreq.go which is not built
e.g. on Linux, so move it there.

Change-Id: I18b2e2ec8f321db3df164dcc6a69b8c92e6ab68c
Reviewed-on: https://go-review.googlesource.com/c/net/+/220097
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
2020-02-19 18:36:38 +00:00
Nigel Tao
16171245cf html: add the RawNode NodeType
Fixes golang/go#36350

Change-Id: Ia11b65940949b7da996b194d48372bc6219d4baa
Reviewed-on: https://go-review.googlesource.com/c/net/+/216800
Reviewed-by: Kunpei Sakai <namusyaka@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-02-02 09:46:26 +00:00
Pure White
6afb5195e5 http2: fix typo in comment
Change-Id: I9c147e3c8f91c3375691503eed70d921f31bd2cc
GitHub-Last-Rev: 462426c8d1
GitHub-Pull-Request: golang/net#61
Reviewed-on: https://go-review.googlesource.com/c/net/+/214602
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2020-01-14 15:54:13 +00:00
Alexandr Mayorskiy
c0dbc17a35 webdav: allow empty host in move
interpret empty host as current

Change-Id: I70be8aa33c0e501df22a8ad17b7b430620d45da6
GitHub-Last-Rev: 28224d33df
GitHub-Pull-Request: golang/net#44
Reviewed-on: https://go-review.googlesource.com/c/net/+/181698
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-12-09 16:08:50 +00:00
Kunpei Sakai
e7e4b65ae6 html: improve coding style
Change-Id: I05c0ccbad41f5512f8096b0d15991d7d6b5d726e
Reviewed-on: https://go-review.googlesource.com/c/net/+/209398
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-12-07 00:06:13 +00:00
Kunpei Sakai
51f093181b html: update adoption agency algorithm
See: https://html.spec.whatwg.org/multipage/parsing.html#adoption-agency-algorithm

This follows up on golang.org/cl/205617

Change-Id: I45862eb81ed421b327e216254169355e63698716
Reviewed-on: https://go-review.googlesource.com/c/net/+/210317
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-12-07 00:05:07 +00:00
Kunpei Sakai
1ddd1de85c html: implement generic raw text element parsing algorithm
See: https://html.spec.whatwg.org/multipage/parsing.html#parsing-elements-that-contain-only-text

This follows up on golang.org/cl/205617

Change-Id: Id99054bc25e9ea90bb3f03b15c14c13573520997
Reviewed-on: https://go-review.googlesource.com/c/net/+/210318
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-12-06 10:30:17 +00:00
Kunpei Sakai
afd1edf42a html: drop <isindex> and <command> specific handlings
This commit also adds remaining tests to follow up on golang.org/cl/205617

Change-Id: I8b155f9f605c6a0eb8745c32f5e785f5b4bc1c7e
Reviewed-on: https://go-review.googlesource.com/c/net/+/208937
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-12-06 10:28:45 +00:00
Fazlul Shahriar
5ee1b9f485 http2: workaround TCPConn CloseWrite not being supported on Plan 9
This stops the tests from hanging on Plan 9.

Fixes golang/go#35904
Updates golang/go#17906

Change-Id: I2bcbb131629b217a99f9496cda0399ce21eb3020
Reviewed-on: https://go-review.googlesource.com/c/net/+/209417
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-04 02:50:24 +00:00
Brad Fitzpatrick
ef20fe5d79 http2: make Transport.IdleConnTimeout consider wall (not monotonic) time
This is the http2 version of CL 204797.

Updates golang/go#29308 (fixes once bundled into std)

Change-Id: I7cd97d38c941e9a8a62808e23b6533c72760f003
Reviewed-on: https://go-review.googlesource.com/c/net/+/208798
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2019-11-26 23:54:20 +00:00
Kunpei Sakai
ffdde10578 html: implement adjusted current node and make parser support foreign fragment
This follows up on golang.org/cl/205617

Change-Id: Id94a4fcef6a604936c404f75999ba37321b6c2c0
Reviewed-on: https://go-review.googlesource.com/c/net/+/206121
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-25 08:49:36 +00:00
Kunpei Sakai
72fef5d5e2 html: remove "filterres" from svg attribute adjustments
This follows up on golang.org/cl/205617
Ref: c0ffd43f89

Change-Id: I0a7399368bb8c28c5bf65adf3614a84ffeb82b8c
Reviewed-on: https://go-review.googlesource.com/c/net/+/206120
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-24 23:54:46 +00:00
Kunpei Sakai
8f7fa2680c html: support #script-(on|off) directives for tests
Those directives are now supported by html5lib-tests.
See: e52ff68cc7/tree-construction/README.md

Also, this fixes missing opts on parsing for identical check

Change-Id: I92f2398ebda0477fd7f6bb438c54f3948063c08d
Reviewed-on: https://go-review.googlesource.com/c/net/+/206118
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-24 23:31:50 +00:00
Kunpei Sakai
b954d4e333 html: add Main support
This follows up on golang.org/cl/205617

Change-Id: Ic4a232c40a69bcd3ba35abdd36bce933f35248ea
Reviewed-on: https://go-review.googlesource.com/c/net/+/206117
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-24 23:23:54 +00:00
Volker Dobler
4163a4da7b publicsuffix: update table to latest list from publicsuffix.org
Update the list to revision 41cb01612341c7ce3bcdd0cc4e696ae9f6416600
(2019-11-08T08:48:39Z).

Change-Id: I2480c0434124f230c4f27161c23e87d8c684e4de
Reviewed-on: https://go-review.googlesource.com/c/net/+/206717
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-24 23:18:49 +00:00
Tobias Klauser
fc4aabc6c9 ipv4, ipv6: use SockFprog definitions from x/sys/unix
This fixes the mips{,64}{,le} builders failing the bpf-related
tests and also avoids duplicating these consts/types across packages.

Fixes golang/go#35669

Change-Id: I1ea96817464e3040e8cc00bff63c168fa5e75a71
Reviewed-on: https://go-review.googlesource.com/c/net/+/207286
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2019-11-19 07:31:36 +00:00
Emmanuel T Odeke
d06c31c94c internal/socket: pass race detection if CGO is not enabled
Follows up CL 205461 by recognizing that -race cannot
run if CGO is not enabled, hence won't broadly fail
the test.

Fixes golang/go#35668

Change-Id: I6a47e6fc7c4afd0bf225fc9876c96b29efa863ce
Reviewed-on: https://go-review.googlesource.com/c/net/+/207677
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2019-11-18 18:34:10 +00:00
Lars Lehtonen
f9c8255933 netutil: fix goroutine error handling in test
Change from a done-channel to an error-channel in
TestLimitListenerError() to collect goroutine errors.

Change-Id: I7fb97a4ee18247123c686fd2b3e6f1bfe93de41e
Reviewed-on: https://go-review.googlesource.com/c/net/+/207465
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-16 16:09:21 +00:00
Keith Randall
2180aed223 internal/socket: tell race detector about syscall reads and writes
The syscalls that send and receive messages write to buffers provided
by the user. The race detector can't see those reads and writes by
default (they are done by the kernel), so we need to tell the race
detector explicitly about them.

Fixes golang/go#35329

Change-Id: Ibf4ef1b937535c4834aa9eeb744722d91f669a27
Reviewed-on: https://go-review.googlesource.com/c/net/+/205461
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2019-11-12 18:23:07 +00:00
JP Sugarbroad
daa7c04131 internal/timeseries: avoid storing numbers as durations
... even if it does avoid a cast. advance isn't a duration and shouldn't be typed that way.

Change-Id: I6328188e74010d6c57adf5b26beede57b3bc7e33
GitHub-Last-Rev: 281097649e
GitHub-Pull-Request: golang/net#29
Reviewed-on: https://go-review.googlesource.com/c/net/+/161297
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-09 02:19:31 +00:00
Lars Lehtonen
c7154b74f1 webdav: fix dropped test error
Picks up a dropped error in TestMemLSConfirm().

Change-Id: Idfbb0fc37dcbec55b0ec6343221dcd9310f474b8
Reviewed-on: https://go-review.googlesource.com/c/net/+/206218
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-11-08 22:53:01 +00:00
songjiayang
4ba9e2ef06 icmp: fix ListenPacket panic
Fixes golang/go#32933

Change-Id: I837d6a54e51d91ff3260ec7e1c79412c52dff20d
Reviewed-on: https://go-review.googlesource.com/c/net/+/185317
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-08 22:14:43 +00:00
Brad Fitzpatrick
42ef8dbebe http2: add missing test update from CL 200317
I forgot to run the trybots on my CL 200317 and also forgot to include
the test update. Whoops.

Change-Id: I5453f6a7314daa49429b6a3ee49a1b5710c05803
Reviewed-on: https://go-review.googlesource.com/c/net/+/206217
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2019-11-08 22:14:34 +00:00
Lars Lehtonen
9aaf51ad5c netutil: fix test to not t.Fatal from goroutine
Change-Id: I07941ecadf7d7268542d13b402436b6111772d02
GitHub-Last-Rev: aece213e50
GitHub-Pull-Request: golang/net#57
Reviewed-on: https://go-review.googlesource.com/c/net/+/203877
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2019-11-08 22:12:41 +00:00
Brad Fitzpatrick
380dde419d http2: make CipherSuites validation error more verbose
Fixes golang/go#34776

Change-Id: Ib76e687780781d9cc59346f722d0ea4ec033ce77
Reviewed-on: https://go-review.googlesource.com/c/net/+/200317
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2019-11-08 17:45:45 +00:00
Kunpei Sakai
7e6e90b9ea html: port html5lib test data from html5lib/html5lib-tests
1. git clone git@github.com:html5lib/html5lib-tests.git && git checkout 88b8ee967f9f6f42fcd84c65af774860a70ecf3c
2. cp -Rv html5lib-tests/tree-construction/ into testdata/webkit
3. Drop unpassed following changes:

testdata/webkit/foreign-fragment.dat
testdata/webkit/isindex.dat
testdata/webkit/main-element.dat
testdata/webkit/menuitem-element.dat
testdata/webkit/tests11.dat
testdata/webkit/tests16.dat
testdata/webkit/tests19.dat
testdata/webkit/tests25.dat
testdata/webkit/tests5.dat
testdata/webkit/webkit02.dat

Change-Id: Ie60b6e24751a1efb83caf326b7e42f0517ec6b96
Reviewed-on: https://go-review.googlesource.com/c/net/+/205617
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-08 06:38:44 +00:00
Kunpei Sakai
6f6bbb1828 html: add Dialog support
Change-Id: I16afe71ca444afb03526f94e6743a587cd82a8d4
Reviewed-on: https://go-review.googlesource.com/c/net/+/205618
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
2019-11-08 04:52:52 +00:00
Mikio Hara
a882066a44 nettest: use unixStrmDgramEnabled on AIX
Also makes parsing the output of oslevel safe.

Change-Id: I72dda3e5f49f40413563ad40396961c3c794c63d
Reviewed-on: https://go-review.googlesource.com/c/net/+/173078
Run-TryBot: Mikio Hara <mikioh.public.networking@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Clément Chigot <clement.chigot%atos.net@gtempaccount.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
2019-11-05 08:49:25 +00:00
Marcel van Lohuizen
0deb6923b6 idna: update tables to Unicode 12
Change-Id: Iccaeb8f986263aacda9b10c6a945c2dddbdec79f
Reviewed-on: https://go-review.googlesource.com/c/net/+/204498
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-01 17:50:33 +00:00
Brad Fitzpatrick
fe3aa8a452 ipv4: use unsafe.Sizeof on struct size, not pointer size
Fix for CL 203400.

Change-Id: Ia0006cdeff4992a218c7a355bd83354138706833
Reviewed-on: https://go-review.googlesource.com/c/net/+/203777
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-10-28 08:55:09 +00:00