github/golang.net
2
0
Fork 0
mirror of https://github.com/golang/net.git synced 2026-04-01 02:47:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

http2: skip OS-dependent tests on Plan 9

Browse Source 
In x/net/http2, tests TestServer_RejectsLargeFrames and
TestTransportBodyReadError_* are disabled on Windows because
they fail or flake, being dependent on the behaviour of the
OS network implementation when a connection is closed during
a large write.

The tests fail on Plan 9 for the same reason, so they should be
disabled there as well.

Workaround for golang/go#31260

Fixes golang/go#37321

Change-Id: Ifa1766eaa515c419fc4192126aaf796beefead0a
Reviewed-on: https://go-review.googlesource.com/c/net/+/231877
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
This commit is contained in:
Richard Miller
2020-05-04 12:11:31 +01:00
committed by David du Colombier
parent a91f0712d1
commit d87ec0cfa4
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
http2/server_test.go
View File

@@ -1189,8 +1189,8 @@ func TestServer_MaxQueuedControlFrames(t *testing.T) {
}
func TestServer_RejectsLargeFrames(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("see golang.org/issue/13434")
if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
t.Skip("see golang.org/issue/13434, golang.org/issue/37321")
}
st := newServerTester(t, nil)

6
http2/transport_test.go
View File

@@ -4322,13 +4322,13 @@ func (r *errReader) Read(p []byte) (int, error) {
}
func testTransportBodyReadError(t *testing.T, body []byte) {
if runtime.GOOS == "windows" {
// So far we've only seen this be flaky on Windows,
if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
// So far we've only seen this be flaky on Windows and Plan 9,
// perhaps due to TCP behavior on shutdowns while
// unread data is in flight. This test should be
// fixed, but a skip is better than annoying people
// for now.
t.Skip("skipping flaky test on Windows; https://golang.org/issue/31260")
t.Skipf("skipping flaky test on %s; https://golang.org/issue/31260", runtime.GOOS)
}
clientDone := make(chan struct{})
ct := newClientTester(t)