Damien Neil 22a8c02e92 http2: remove test-only path in requestBody.Read ...

requestBody.Read avoids panicking when requestBody.conn is unset
and we are in tests. This seems like an excellent way to hide a
non-test panic. Drop the exceptional path.

This path was introduced in golang.org/cl/31636 to support a
test verifying that concurrently closing and reading from a
Request.Body does not race. Rewrite this test to use a real
server handler.

Change-Id: I778e78ff9ab45e248769557fff94d17940eb7a18
Reviewed-on: https://go-review.googlesource.com/c/net/+/701000
Auto-Submit: Nicholas Husin <nsh@golang.org>
Reviewed-by: Nicholas Husin <husin@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <nsh@golang.org>

2025-09-08 07:14:52 -07:00

..

h2c

http2/h2c: use ResponseController for hijacking connections

2025-03-08 12:58:08 -08:00

h2i

all: update go directive to 1.18

2023-10-11 21:58:12 +00:00

hpack

all: replace deprecated io/ioutil calls

2024-05-21 19:59:00 +00:00

.gitignore

…

ascii_test.go

…

ascii.go

…

ciphers_test.go

http2: fix spec document links

2022-08-02 22:28:14 +00:00

ciphers.go

…

client_conn_pool.go

http2: support unencrypted HTTP/2 handoff from net/http

2024-11-05 19:37:20 +00:00

clientconn_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

config_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

config.go

http2: remove pre-go1.24 support

2025-09-05 11:15:48 -07:00

connframes_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

databuffer_test.go

…

databuffer.go

http2: allocate buffer pools using pointers to arrays

2023-11-07 21:56:53 +00:00

errors_test.go

…

errors.go

net/http2: omit invalid header value from error message

2022-04-03 10:30:23 +00:00

flow_test.go

http2: rewrite inbound flow control tracking

2023-01-03 19:04:08 +00:00

flow.go

all: fix some comments

2023-02-08 14:49:55 +00:00

frame_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

frame.go

http2: correctly wrap ErrFrameTooLarge in Framer.ReadFrame

2025-05-27 23:45:28 -07:00

gotrack_test.go

…

gotrack.go

…

http2_test.go

http2: don't panic when ServeConn is passed a nil options

2025-09-05 13:18:06 -07:00

http2.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

netconn_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

pipe_test.go

all: replace deprecated io/ioutil calls

2024-05-21 19:59:00 +00:00

pipe.go

http2: prevent uninitialized pipe from being written

2024-03-08 17:42:06 +00:00

server_push_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

server_test.go

http2: remove test-only path in requestBody.Read

2025-09-08 07:14:52 -07:00

server.go

http2: remove test-only path in requestBody.Read

2025-09-08 07:14:52 -07:00

synctest_go124_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

synctest_go125_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

transport_test.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

transport.go

http2: use testing/synctest

2025-09-05 11:08:28 -07:00

unencrypted.go

http2: support unencrypted HTTP/2 handoff from net/http

2024-11-05 19:37:20 +00:00

write.go

http2, internal/httpcommon: factor out common request header logic for h2/h3

2025-01-24 11:09:29 -08:00

writesched_priority_test.go

http2: avoid corruption in priority write scheduler

2024-05-30 19:26:57 +00:00

writesched_priority.go

http2: avoid corruption in priority write scheduler

2024-05-30 19:26:57 +00:00

writesched_random_test.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched_random.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched_roundrobin_test.go

http2: change default frame scheduler to round robin

2023-05-15 16:53:19 +00:00

writesched_roundrobin.go

http2: change default frame scheduler to round robin

2023-05-15 16:53:19 +00:00

writesched_test.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched.go

http2: change default frame scheduler to round robin

2023-05-15 16:53:19 +00:00