github/golang.net
2
0
Fork 0
mirror of https://github.com/golang/net.git synced 2026-03-31 18:37:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

http2: disable a flaky test on Windows for now, add more logging

Browse Source 
Updates golang/go#31260

Change-Id: Icf26461dc48f5f16a91a93df6aa78fec1338f51f
Reviewed-on: https://go-review.googlesource.com/c/net/+/181198
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Brad Fitzpatrick
2019-06-07 17:09:25 +00:00
parent 27ecd3f315
commit d5cec38845
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
http2/transport_test.go
View File

@@ -4230,6 +4230,14 @@ func (r *errReader) Read(p []byte) (int, error) {
}
func testTransportBodyReadError(t *testing.T, body []byte) {
if runtime.GOOS == "windows" {
// So far we've only seen this be flaky on Windows,
// perhaps due to TCP behavior on shutdowns while
// unread data is in flight. This test should be
// fixed, but a skip is better than annoying people
// for now.
t.Skip("skipping flaky test on Windows; https://golang.org/issue/31260")
}
clientDone := make(chan struct{})
ct := newClientTester(t)
ct.client = func() error {
@@ -4276,6 +4284,7 @@ func testTransportBodyReadError(t *testing.T, body []byte) {
var resetCount int
for {
f, err := ct.fr.ReadFrame()
t.Logf("server: ReadFrame = %v, %v", f, err)
if err != nil {
select {
case <-clientDone:
@@ -4283,7 +4292,7 @@ func testTransportBodyReadError(t *testing.T, body []byte) {
// will have reported any
// errors on its side.
if bytes.Compare(receivedBody, body) != 0 {
return fmt.Errorf("body: %v; expected %v", receivedBody, body)
return fmt.Errorf("body: %q; expected %q", receivedBody, body)
}
if resetCount != 1 {
return fmt.Errorf("stream reset count: %v; expected: 1", resetCount)