github/golang.net
2
0
Fork 0
mirror of https://github.com/golang/net.git synced 2026-03-31 10:27:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

proxy: add mention of RFC 1929 for SOCKS5

Browse Source 
RFC 1929 describes the SOCKS5 username/password authentication method.
The proxy package implements this method, but doesn't mention RFC 1929.
This change adds mention of RFC 1929.

Change-Id: I30487fb41c1baa16b6ee8a99210168a597e5cb65
Reviewed-on: https://go-review.googlesource.com/60870
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
Reviewed-by: Avelino <t@avelino.xxx>
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Joe Kyo
2017-09-01 10:04:45 +01:00
committed by Mikio Hara
parent b60f3a9210
commit 0744d001aa
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
proxy/socks5.go
View File

@@ -12,7 +12,7 @@ import (
)
// SOCKS5 returns a Dialer that makes SOCKSv5 connections to the given address
// with an optional username and password. See RFC 1928.
// with an optional username and password. See RFC 1928 and 1929.
func SOCKS5(network, addr string, auth *Auth, forward Dialer) (Dialer, error) {
s := &socks5{
network: network,
@@ -120,6 +120,7 @@ func (s *socks5) connect(conn net.Conn, target string) error {
return errors.New("proxy: SOCKS5 proxy at " + s.addr + " requires authentication")
}
// See RFC 1929
if buf[1] == socks5AuthPassword {
buf = buf[:0]
buf = append(buf, 1 /* password protocol version */)