Make setting options global

cmd/micro/command.go

@@ -165,12 +165,14 @@ func NewTab(args []string) {
 
 // Set sets an option
 func Set(args []string) {
-	// Set an option and we have to set it for every view
+	if len(args) < 2 {
-	for _, tab := range tabs {
+		return
-		for _, view := range tab.views {
-			SetOption(view, args)
-		}
 	}
+
+	option := strings.TrimSpace(args[0])
+	value := strings.TrimSpace(args[1])
+
+	SetOption(option, value)
 }
 
 // Bind creates a new keybinding

cmd/micro/micro.go

@@ -262,6 +262,7 @@ func main() {
 	L.SetGlobal("messenger", luar.New(L, messenger))
 	L.SetGlobal("GetOption", luar.New(L, GetOption))
 	L.SetGlobal("AddOption", luar.New(L, AddOption))
+	L.SetGlobal("SetOption", luar.New(L, SetOption))
 	L.SetGlobal("BindKey", luar.New(L, BindKey))
 	L.SetGlobal("MakeCommand", luar.New(L, MakeCommand))
 	L.SetGlobal("CurView", luar.New(L, CurView))

cmd/micro/settings.go

@@ -6,7 +6,6 @@ import (
 	"os"
 	"reflect"
 	"strconv"
-	"strings"
 )
 
 // The options that the user can set
@@ -90,12 +89,8 @@ func DefaultSettings() map[string]interface{} {
 }
 
 // SetOption prompts the user to set an option and checks that the response is valid
-func SetOption(view *View, args []string) {
+func SetOption(option, value string) {
 	filename := configDir + "/settings.json"
-	if len(args) == 2 {
-		option := strings.TrimSpace(args[0])
-		value := strings.TrimSpace(args[1])
-
 	if _, ok := settings[option]; !ok {
 		messenger.Error(option + " is not a valid option")
 		return
@@ -122,11 +117,25 @@ func SetOption(view *View, args []string) {
 
 	if option == "colorscheme" {
 		LoadSyntaxFiles()
+		for _, tab := range tabs {
+			for _, view := range tab.views {
 				view.Buf.UpdateRules()
+				if settings["syntax"].(bool) {
+					view.matches = Match(view)
+				}
+			}
+		}
 	}
 
 	if option == "statusline" {
+		for _, tab := range tabs {
+			for _, view := range tab.views {
 				view.ToggleStatusLine()
+				if settings["syntax"].(bool) {
+					view.matches = Match(view)
+				}
+			}
+		}
 	}
 
 	err := WriteSettings(filename)
@@ -134,7 +143,4 @@ func SetOption(view *View, args []string) {
 		messenger.Error("Error writing to settings.json: " + err.Error())
 		return
 	}
-	} else {
-		messenger.Error("No value given")
-	}
 }