From e0f5361d97a77806afde6a0887d0cb2c09ab8508 Mon Sep 17 00:00:00 2001 From: Dmytro Maluka Date: Sat, 17 Aug 2024 16:44:53 +0200 Subject: [PATCH] calcHash: remove unneeded h.Write() error checks According to the Go hash package documentation [1]: type Hash interface { // Write (via the embedded io.Writer interface) adds more data to the running hash. // It never returns an error. io.Writer [1] https://pkg.go.dev/hash#Hash --- internal/buffer/buffer.go | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/internal/buffer/buffer.go b/internal/buffer/buffer.go index 661ea8b5..a7aca541 100644 --- a/internal/buffer/buffer.go +++ b/internal/buffer/buffer.go @@ -654,22 +654,13 @@ func calcHash(b *Buffer, out *[md5.Size]byte) error { size := 0 if len(b.lines) > 0 { - n, e := h.Write(b.lines[0].data) - if e != nil { - return e - } + n, _ := h.Write(b.lines[0].data) size += n for _, l := range b.lines[1:] { - n, e = h.Write([]byte{'\n'}) - if e != nil { - return e - } + n, _ = h.Write([]byte{'\n'}) size += n - n, e = h.Write(l.data) - if e != nil { - return e - } + n, _ = h.Write(l.data) size += n } }