github/zyedidia.micro
2
0
Fork 0
mirror of https://github.com/zyedidia/micro.git synced 2026-03-30 06:37:14 +09:00
Code Issues Packages Projects Releases Wiki Activity

PM should not install already installed plugins.

Browse Source
This commit is contained in:
Florian Sundermann
2016-09-28 16:34:28 +02:00
parent f3f4790103
commit cce36624dc
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
cmd/micro/pluginmanager.go
View File

@@ -320,6 +320,7 @@ func GetInstalledPluginVersion(name string) string {
} }
func (pv *PluginVersion) DownloadAndInstall() error { func (pv *PluginVersion) DownloadAndInstall() error {
messenger.AddLog(fmt.Sprintf("Downloading %q (%s) from %q", pv.pack.Name, pv.Version, pv.Url))
resp, err := http.Get(pv.Url) resp, err := http.Get(pv.Url)
if err != nil { if err != nil {
return err return err
@@ -440,17 +441,27 @@ func (all PluginPackages) Resolve(selectedVersions PluginVersions, open PluginDe
func (versions PluginVersions) install() { func (versions PluginVersions) install() {
anyInstalled := false anyInstalled := false
currentlyInstalled := GetInstalledVersions()
for _, sel := range versions { for _, sel := range versions {
if sel.pack.Name != CorePluginName { if sel.pack.Name != CorePluginName {
installed := GetInstalledPluginVersion(sel.pack.Name) shouldInstall := true
if v, err := semver.ParseTolerant(installed); err != nil || v.NE(sel.Version) { if pv := currentlyInstalled.find(sel.pack.Name); pv != nil {
UninstallPlugin(sel.pack.Name) if pv.Version.NE(sel.Version) {
messenger.AddLog(fmt.Sprint("Uninstalling %q", sel.pack.Name))
UninstallPlugin(sel.pack.Name)
} else {
shouldInstall = false
}
} }
if err := sel.DownloadAndInstall(); err != nil {
messenger.Error(err) if shouldInstall {
return if err := sel.DownloadAndInstall(); err != nil {
messenger.Error(err)
return
}
anyInstalled = true
} }
anyInstalled = true
} }
} }
if anyInstalled { if anyInstalled {