From b05df07df214c564d9b02e99e44ace9c37a1e16f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6ran=20Karl?= <3951388+JoeKar@users.noreply.github.com> Date: Thu, 25 Apr 2024 18:42:00 +0200 Subject: [PATCH] bindings: Small refactoring of `TryBindKey()` for better readability --- internal/action/bindings.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/internal/action/bindings.go b/internal/action/bindings.go index 71b5570e..0b940ebf 100644 --- a/internal/action/bindings.go +++ b/internal/action/bindings.go @@ -294,21 +294,23 @@ func TryBindKey(k, v string, overwrite bool) (bool, error) { } found := false - for ev := range parsed { + var ev string + for ev = range parsed { if e, err := findEvent(ev); err == nil { if eventsEqual(e, key) { - if overwrite { - parsed[ev] = v - } found = true break } } } - if found && !overwrite { - return true, nil - } else if !found { + if found { + if overwrite { + parsed[ev] = v + } else { + return true, nil + } + } else { parsed[k] = v }