From a373d22939d7ea5e918ac8d29f8a8275571ec9c1 Mon Sep 17 00:00:00 2001 From: Dmitry Maluka Date: Fri, 3 Nov 2023 01:07:29 +0100 Subject: [PATCH] Refactor defaultvalue setting a bit --- internal/config/settings.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/config/settings.go b/internal/config/settings.go index eb377d11..6494c1f3 100644 --- a/internal/config/settings.go +++ b/internal/config/settings.go @@ -229,30 +229,26 @@ func RegisterGlobalOptionPlug(pl string, name string, defaultvalue interface{}) // RegisterCommonOption creates a new option func RegisterCommonOption(name string, defaultvalue interface{}) error { if _, ok := GlobalSettings[name]; !ok { - defaultCommonSettings[name] = defaultvalue GlobalSettings[name] = defaultvalue err := WriteSettings(filepath.Join(ConfigDir, "settings.json")) if err != nil { return errors.New("Error writing settings.json file: " + err.Error()) } - } else { - defaultCommonSettings[name] = defaultvalue } + defaultCommonSettings[name] = defaultvalue return nil } // RegisterGlobalOption creates a new global-only option func RegisterGlobalOption(name string, defaultvalue interface{}) error { if _, ok := GlobalSettings[name]; !ok { - DefaultGlobalOnlySettings[name] = defaultvalue GlobalSettings[name] = defaultvalue err := WriteSettings(filepath.Join(ConfigDir, "settings.json")) if err != nil { return errors.New("Error writing settings.json file: " + err.Error()) } - } else { - DefaultGlobalOnlySettings[name] = defaultvalue } + DefaultGlobalOnlySettings[name] = defaultvalue return nil }