From 59e71a4a0c420d9f2a521a5cab8f07829dc00062 Mon Sep 17 00:00:00 2001 From: Zachary Yedidia Date: Sat, 30 Apr 2016 14:30:42 -0400 Subject: [PATCH] Improved error parsing and use warnings for golint instead of errors --- cmd/micro/view.go | 1 + runtime/plugins/go/go.lua | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/cmd/micro/view.go b/cmd/micro/view.go index be7ff115..1a685407 100644 --- a/cmd/micro/view.go +++ b/cmd/micro/view.go @@ -401,6 +401,7 @@ func (v *View) GutterMessage(section string, lineN int, msg string, kind int) { v.messages[section] = append(messages, gutterMsg) } +// ClearGutterMessages clears all gutter messages from a given section func (v *View) ClearGutterMessages(section string) { v.messages[section] = []GutterMessage{} } diff --git a/runtime/plugins/go/go.lua b/runtime/plugins/go/go.lua index 4b2fcd8e..73608160 100644 --- a/runtime/plugins/go/go.lua +++ b/runtime/plugins/go/go.lua @@ -37,21 +37,23 @@ function go_golint() local line = tonumber(result[2]) local msg = result[4] - view:GutterMessage("go-lint", line, msg, 2) + view:GutterMessage("go-lint", line, msg, 1) end end function go_build() view:ClearGutterMessages("go-build") - local handle = io.popen("go build " .. view.Buf.Path .. " 2>&1") + local handle = io.popen("go build -o /dev/null 2>&1") local lines = go_split(handle:read("*a"), "\n") handle:close() messenger:Message(view.Buf.Path) for _,line in ipairs(lines) do - local line, msg = string.match(line, ".+:(%d+):(.+)") - view:GutterMessage("go-build", tonumber(line), msg, 2) + if string.find(line, ".+:(%d+):(.+)") then + local line, msg = string.match(line, ".+:(%d+):(.+)") + view:GutterMessage("go-build", tonumber(line), msg, 2) + end end end