From 0c923aa156d9bd2aefba8b6e6e04f15d970ec725 Mon Sep 17 00:00:00 2001 From: Dmytro Maluka Date: Sat, 23 Mar 2024 18:29:03 +0100 Subject: [PATCH] UpdateRules: don't call highlight.ParseFile() needlessly No need to parse a syntax YAML file if we are not going to use it, it's a waste of CPU cycles. --- internal/buffer/buffer.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/internal/buffer/buffer.go b/internal/buffer/buffer.go index 0ba7aa62..178cd5c8 100644 --- a/internal/buffer/buffer.go +++ b/internal/buffer/buffer.go @@ -718,13 +718,14 @@ func (b *Buffer) UpdateRules() { screen.TermMessage("Error parsing header for syntax file " + f.Name() + ": " + err.Error()) continue } - file, err := highlight.ParseFile(data) - if err != nil { - screen.TermMessage("Error parsing syntax file " + f.Name() + ": " + err.Error()) - continue - } if ((ft == "unknown" || ft == "") && header.MatchFileName(b.Path)) || header.FileType == ft { + file, err := highlight.ParseFile(data) + if err != nil { + screen.TermMessage("Error parsing syntax file " + f.Name() + ": " + err.Error()) + continue + } + syndef, err := highlight.ParseDef(file, header) if err != nil { screen.TermMessage("Error parsing syntax file " + f.Name() + ": " + err.Error())