mirror of
https://github.com/golang/net.git
synced 2026-04-01 02:47:08 +09:00
We use uint8 (0-255, inclusive) to represent the RFC 7540 priorities weight (1-256, inclusive). To account for the difference, we add 1 to the uint8 weight value within sortPriorityNodeSiblingsRFC7540. However, the addition was done before converting the uint8 type to float. As a result, when provided a maximum weight value, overflow will happen and will cause the scheduler to treat the maximum weight as a minimum weight instead. This CL fixes the issue by making sure the addition happens after the type conversion. Change-Id: I404e87e5ad85fa06d5fa49cda613c93ac8847bdc Reviewed-on: https://go-review.googlesource.com/c/net/+/714742 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Nicholas Husin <husin@google.com>