Damien Neil f3363e06e7 http2: handle server errors after sending GOAWAY ...

The HTTP/2 server uses serverConn.goAwayCode to track whether a
connection has encountered a fatal error. If an error is encountered
after sending a ErrCodeNo GOAWAY, upgrade goAwayCode to reflect the
error status of the connection.

Fixes an issue where a server connection could hang forever waiting
for a clean shutdown that was preempted by a subsequent fatal error.

Fixes CVE-2022-27664
For golang/go#53977

Change-Id: I165b81ab53176c77a68c42976030499d57bb05d3
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1413887
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Reviewed-on: https://go-review.googlesource.com/c/net/+/428735
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>

2022-09-06 16:51:46 +00:00

..

h2c

http2/h2c: support direct hand off of h2c-upgrade connections

2022-05-24 22:04:25 +00:00

h2i

http2/h2i: update install documentation

2022-07-06 16:39:47 +00:00

hpack

http2: fix spec document links

2022-08-02 22:28:14 +00:00

testdata

all: fix typos

2021-07-26 21:34:35 +00:00

.gitignore

…

ascii_test.go

http2: switch to ASCII equivalents of string functions

2021-05-10 09:51:57 +00:00

ascii.go

http2: check that Unicode-aware functions are not used

2021-06-10 13:23:58 +00:00

ciphers_test.go

http2: fix spec document links

2022-08-02 22:28:14 +00:00

ciphers.go

all: use HTTPS for iana.org links

2018-01-24 06:09:56 +00:00

client_conn_pool.go

http2: add newly dialed conns to the pool before signaling completion

2022-06-15 17:15:55 +00:00

databuffer_test.go

http2: remove support for Go 1.8 and earlier

2018-11-01 15:51:06 +00:00

databuffer.go

http2: replace fixedBuffer with dataBuffer

2017-02-24 20:07:17 +00:00

Dockerfile

http2: update curl download location in Dockerfile

2021-04-14 19:42:28 +00:00

errors_test.go

…

errors.go

net/http2: omit invalid header value from error message

2022-04-03 10:30:23 +00:00

flow_test.go

http2: correct overflow protection

2018-06-28 19:26:13 +00:00

flow.go

http2: mark some structs as non-comparable

2020-05-01 05:30:45 +00:00

frame_test.go

net/http2: omit invalid header value from error message

2022-04-03 10:30:23 +00:00

frame.go

http2: fix spec document links

2022-08-02 22:28:14 +00:00

go111.go

all: go fmt ./...

2021-02-20 03:31:24 +00:00

go115.go

crypto/tls: don't use tls.Dialer on pre-Go1.15 systems

2021-05-05 21:49:59 +00:00

go118.go

http2: improve handling of slow-closing net.Conns

2022-02-25 17:22:49 +00:00

gotrack_test.go

…

gotrack.go

…

headermap.go

http2: switch to ASCII equivalents of string functions

2021-05-10 09:51:57 +00:00

http2_test.go

http2: check that Unicode-aware functions are not used

2021-06-10 13:23:58 +00:00

http2.go

http2: fix spec document links

2022-08-02 22:28:14 +00:00

Makefile

…

not_go111.go

all: go fmt ./...

2021-02-20 03:31:24 +00:00

not_go115.go

crypto/tls: don't use tls.Dialer on pre-Go1.15 systems

2021-05-05 21:49:59 +00:00

not_go118.go

http2: improve handling of slow-closing net.Conns

2022-02-25 17:22:49 +00:00

pipe_test.go

http2: track unread bytes when the pipe is broken

2019-10-14 20:34:26 +00:00

pipe.go

http2: refactor request write flow

2021-10-04 16:44:53 +00:00

server_push_test.go

http2: remove support for Go 1.8 and earlier

2018-11-01 15:51:06 +00:00

server_test.go

http2: handle server errors after sending GOAWAY

2022-09-06 16:51:46 +00:00

server.go

http2: handle server errors after sending GOAWAY

2022-09-06 16:51:46 +00:00

transport_go117_test.go

http2: use (*tls.Dialer).DialContext in dialTLS

2021-05-04 13:21:25 +00:00

transport_test.go

Revert "http2: enable VerboseLogs in TestTransportGroupsPendingDials"

2022-06-21 19:30:19 +00:00

transport.go

http2: add DialTLSContext to Transport

2022-08-12 16:54:38 +00:00

write.go

http2: switch to ASCII equivalents of string functions

2021-05-10 09:51:57 +00:00

writesched_priority_test.go

http2: prioritize RST_STREAM frames in priority write scheduler

2022-05-31 18:57:40 +00:00

writesched_priority.go

http2: prioritize RST_STREAM frames in priority write scheduler

2022-05-31 18:57:40 +00:00

writesched_random_test.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched_random.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched_test.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

writesched.go

http2: prioritize RST_STREAM frames in random write scheduler

2021-12-08 00:02:02 +00:00

z_spec_test.go

…