mirror of
https://github.com/golang/net.git
synced 2026-04-01 02:47:08 +09:00
3470a06c13
Case happens if Read is called after it has already returned an error previously. Verified that the new TestPipeCloseWithError test fails before this change but passes after. Updates golang/go#20501 Change-Id: I636fbb194f2d0019b0722556cc25a88da2d18e13 Reviewed-on: https://go-review.googlesource.com/44330 Run-TryBot: Tom Bergan <tombergan@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
131 lines
2.7 KiB
Go
131 lines
2.7 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package http2
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"io"
|
|
"io/ioutil"
|
|
"testing"
|
|
)
|
|
|
|
func TestPipeClose(t *testing.T) {
|
|
var p pipe
|
|
p.b = new(bytes.Buffer)
|
|
a := errors.New("a")
|
|
b := errors.New("b")
|
|
p.CloseWithError(a)
|
|
p.CloseWithError(b)
|
|
_, err := p.Read(make([]byte, 1))
|
|
if err != a {
|
|
t.Errorf("err = %v want %v", err, a)
|
|
}
|
|
}
|
|
|
|
func TestPipeDoneChan(t *testing.T) {
|
|
var p pipe
|
|
done := p.Done()
|
|
select {
|
|
case <-done:
|
|
t.Fatal("done too soon")
|
|
default:
|
|
}
|
|
p.CloseWithError(io.EOF)
|
|
select {
|
|
case <-done:
|
|
default:
|
|
t.Fatal("should be done")
|
|
}
|
|
}
|
|
|
|
func TestPipeDoneChan_ErrFirst(t *testing.T) {
|
|
var p pipe
|
|
p.CloseWithError(io.EOF)
|
|
done := p.Done()
|
|
select {
|
|
case <-done:
|
|
default:
|
|
t.Fatal("should be done")
|
|
}
|
|
}
|
|
|
|
func TestPipeDoneChan_Break(t *testing.T) {
|
|
var p pipe
|
|
done := p.Done()
|
|
select {
|
|
case <-done:
|
|
t.Fatal("done too soon")
|
|
default:
|
|
}
|
|
p.BreakWithError(io.EOF)
|
|
select {
|
|
case <-done:
|
|
default:
|
|
t.Fatal("should be done")
|
|
}
|
|
}
|
|
|
|
func TestPipeDoneChan_Break_ErrFirst(t *testing.T) {
|
|
var p pipe
|
|
p.BreakWithError(io.EOF)
|
|
done := p.Done()
|
|
select {
|
|
case <-done:
|
|
default:
|
|
t.Fatal("should be done")
|
|
}
|
|
}
|
|
|
|
func TestPipeCloseWithError(t *testing.T) {
|
|
p := &pipe{b: new(bytes.Buffer)}
|
|
const body = "foo"
|
|
io.WriteString(p, body)
|
|
a := errors.New("test error")
|
|
p.CloseWithError(a)
|
|
all, err := ioutil.ReadAll(p)
|
|
if string(all) != body {
|
|
t.Errorf("read bytes = %q; want %q", all, body)
|
|
}
|
|
if err != a {
|
|
t.Logf("read error = %v, %v", err, a)
|
|
}
|
|
// Read and Write should fail.
|
|
if n, err := p.Write([]byte("abc")); err != errClosedPipeWrite || n != 0 {
|
|
t.Errorf("Write(abc) after close\ngot %v, %v\nwant 0, %v", n, err, errClosedPipeWrite)
|
|
}
|
|
if n, err := p.Read(make([]byte, 1)); err == nil || n != 0 {
|
|
t.Errorf("Read() after close\ngot %v, nil\nwant 0, %v", n, errClosedPipeWrite)
|
|
}
|
|
}
|
|
|
|
func TestPipeBreakWithError(t *testing.T) {
|
|
p := &pipe{b: new(bytes.Buffer)}
|
|
io.WriteString(p, "foo")
|
|
a := errors.New("test err")
|
|
p.BreakWithError(a)
|
|
all, err := ioutil.ReadAll(p)
|
|
if string(all) != "" {
|
|
t.Errorf("read bytes = %q; want empty string", all)
|
|
}
|
|
if err != a {
|
|
t.Logf("read error = %v, %v", err, a)
|
|
}
|
|
if p.b != nil {
|
|
t.Errorf("buffer should be nil after BreakWithError")
|
|
}
|
|
// Write should succeed silently.
|
|
if n, err := p.Write([]byte("abc")); err != nil || n != 3 {
|
|
t.Errorf("Write(abc) after break\ngot %v, %v\nwant 0, nil", n, err)
|
|
}
|
|
if p.b != nil {
|
|
t.Errorf("buffer should be nil after Write")
|
|
}
|
|
// Read should fail.
|
|
if n, err := p.Read(make([]byte, 1)); err == nil || n != 0 {
|
|
t.Errorf("Read() after close\ngot %v, nil\nwant 0, not nil", n)
|
|
}
|
|
}
|