mirror of
https://github.com/golang/net.git
synced 2026-03-31 18:37:08 +09:00
9e1fb3c175
HEADERS and CONTINUATION frames are special in that they must appear
contiguous on the wire and there are lots of annoying details to
verify while working through its state machine, including the handling
of hpack header list size limits and DoS vectors.
We now have three implementations of this merging (Server, Transport,
and grpc), and grpc's is not complete. The Transport's was also
partially incomplete.
Move this up to the Framer (opt-in, for compatibility) and remove the
support from the Server and Transport. I can fix grpc later to use
this.
Recommended reviewing order:
* hpack.go exports the HeaderField.Size method and adds an IsPseudo
method.
* errors.go adds some new unexported error types, for testing.
* frame.go adds the new type MetaHeadersFrame.
* frame.go adds new fields on Framer for controlling how ReadFrame
behaves
* frame.go Framer.ReadFrame now calls the new Framer.readMetaFrame
method
* frame_test.go adds a bunch of tests. these are largely redundant
with the existing tests which were in server and transport
before. They really belong with frame_test.go, but I also don't want
to delete tests in a CL like this. I probably won't remove them
later either.
* server.go and transport.go can be reviewed in either order at this
point. Both are the fun part of this change: deleting lots of hairy
state machine code (which was redundant in at least 6 ways: server
headers, server trailers, client headers, client trailers, grpc
headers, grpc trailers...). Both server and transport.go have the
general following form:
- set Framer.ReadMetaHeaders
- stop handling *HeadersFrame and *ContinuationFrame; handle
*MetaHeadersFrame instead.
- delete all the state machine + hpack parsing callback hell
The diffstat numbers look like a wash once you exclude the new tests,
but this pays for itself by far when you consider the grpc savings as
well, and the increased simplicity.
Change-Id: If348cf585165b528b7d3ab2e5f86b49a03fbb0d2
Reviewed-on: https://go-review.googlesource.com/19726
Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
123 lines
3.7 KiB
Go
123 lines
3.7 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package http2
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
// An ErrCode is an unsigned 32-bit error code as defined in the HTTP/2 spec.
|
|
type ErrCode uint32
|
|
|
|
const (
|
|
ErrCodeNo ErrCode = 0x0
|
|
ErrCodeProtocol ErrCode = 0x1
|
|
ErrCodeInternal ErrCode = 0x2
|
|
ErrCodeFlowControl ErrCode = 0x3
|
|
ErrCodeSettingsTimeout ErrCode = 0x4
|
|
ErrCodeStreamClosed ErrCode = 0x5
|
|
ErrCodeFrameSize ErrCode = 0x6
|
|
ErrCodeRefusedStream ErrCode = 0x7
|
|
ErrCodeCancel ErrCode = 0x8
|
|
ErrCodeCompression ErrCode = 0x9
|
|
ErrCodeConnect ErrCode = 0xa
|
|
ErrCodeEnhanceYourCalm ErrCode = 0xb
|
|
ErrCodeInadequateSecurity ErrCode = 0xc
|
|
ErrCodeHTTP11Required ErrCode = 0xd
|
|
)
|
|
|
|
var errCodeName = map[ErrCode]string{
|
|
ErrCodeNo: "NO_ERROR",
|
|
ErrCodeProtocol: "PROTOCOL_ERROR",
|
|
ErrCodeInternal: "INTERNAL_ERROR",
|
|
ErrCodeFlowControl: "FLOW_CONTROL_ERROR",
|
|
ErrCodeSettingsTimeout: "SETTINGS_TIMEOUT",
|
|
ErrCodeStreamClosed: "STREAM_CLOSED",
|
|
ErrCodeFrameSize: "FRAME_SIZE_ERROR",
|
|
ErrCodeRefusedStream: "REFUSED_STREAM",
|
|
ErrCodeCancel: "CANCEL",
|
|
ErrCodeCompression: "COMPRESSION_ERROR",
|
|
ErrCodeConnect: "CONNECT_ERROR",
|
|
ErrCodeEnhanceYourCalm: "ENHANCE_YOUR_CALM",
|
|
ErrCodeInadequateSecurity: "INADEQUATE_SECURITY",
|
|
ErrCodeHTTP11Required: "HTTP_1_1_REQUIRED",
|
|
}
|
|
|
|
func (e ErrCode) String() string {
|
|
if s, ok := errCodeName[e]; ok {
|
|
return s
|
|
}
|
|
return fmt.Sprintf("unknown error code 0x%x", uint32(e))
|
|
}
|
|
|
|
// ConnectionError is an error that results in the termination of the
|
|
// entire connection.
|
|
type ConnectionError ErrCode
|
|
|
|
func (e ConnectionError) Error() string { return fmt.Sprintf("connection error: %s", ErrCode(e)) }
|
|
|
|
// StreamError is an error that only affects one stream within an
|
|
// HTTP/2 connection.
|
|
type StreamError struct {
|
|
StreamID uint32
|
|
Code ErrCode
|
|
}
|
|
|
|
func (e StreamError) Error() string {
|
|
return fmt.Sprintf("stream error: stream ID %d; %v", e.StreamID, e.Code)
|
|
}
|
|
|
|
// 6.9.1 The Flow Control Window
|
|
// "If a sender receives a WINDOW_UPDATE that causes a flow control
|
|
// window to exceed this maximum it MUST terminate either the stream
|
|
// or the connection, as appropriate. For streams, [...]; for the
|
|
// connection, a GOAWAY frame with a FLOW_CONTROL_ERROR code."
|
|
type goAwayFlowError struct{}
|
|
|
|
func (goAwayFlowError) Error() string { return "connection exceeded flow control window size" }
|
|
|
|
// connErrorReason wraps a ConnectionError with an informative error about why it occurs.
|
|
|
|
// Errors of this type are only returned by the frame parser functions
|
|
// and converted into ConnectionError(ErrCodeProtocol).
|
|
type connError struct {
|
|
Code ErrCode
|
|
Reason string
|
|
}
|
|
|
|
func (e connError) Error() string {
|
|
return fmt.Sprintf("http2: connection error: %v: %v", e.Code, e.Reason)
|
|
}
|
|
|
|
type pseudoHeaderError string
|
|
|
|
func (e pseudoHeaderError) Error() string {
|
|
return fmt.Sprintf("invalid pseudo-header %q", string(e))
|
|
}
|
|
|
|
type duplicatePseudoHeaderError string
|
|
|
|
func (e duplicatePseudoHeaderError) Error() string {
|
|
return fmt.Sprintf("duplicate pseudo-header %q", string(e))
|
|
}
|
|
|
|
type headerFieldNameError string
|
|
|
|
func (e headerFieldNameError) Error() string {
|
|
return fmt.Sprintf("invalid header field name %q", string(e))
|
|
}
|
|
|
|
type headerFieldValueError string
|
|
|
|
func (e headerFieldValueError) Error() string {
|
|
return fmt.Sprintf("invalid header field value %q", string(e))
|
|
}
|
|
|
|
var (
|
|
errMixPseudoHeaderTypes = errors.New("mix of request and response pseudo headers")
|
|
errPseudoAfterRegular = errors.New("pseudo header field after regular")
|
|
)
|