renthraysk ee2e9a0823 http2: number of allocs reduced from 3852 to 31 ...

buildRootHuffmanNode() was allocating a new node for every leaf of the huffman decoding tree.
This PR allocates an array of nodes for all the leaf nodes, and reuses them.
As buildRootHuffmanNode is only called via sync.Once, it's not significant performance wise, but still seems an unnecessary number of allocations.

benchmark           old ns/op     new ns/op     delta
BenchmarkRoot-4     162847        17911         -89.00%

benchmark           old allocs     new allocs     delta
BenchmarkRoot-4     3852           31             -99.20%

benchmark           old bytes     new bytes     delta
BenchmarkRoot-4     92112         35056         -61.94%

Change-Id: I7c1eae13fb6130090610eec1eb0347d5d1fef20c
GitHub-Last-Rev: f40a4e8530
GitHub-Pull-Request: golang/net#112
Reviewed-on: https://go-review.googlesource.com/c/net/+/346649
Reviewed-by: Damien Neil <dneil@google.com>
Trust: Damien Neil <dneil@google.com>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

2021-10-13 15:36:59 +00:00

..

encode_test.go

…

encode.go

all: fix typos

2019-09-09 00:30:24 +00:00

hpack_test.go

http2/hpack: track the beginning of a header block

2018-12-13 20:27:11 +00:00

hpack.go

http2/hpack: track the beginning of a header block

2018-12-13 20:27:11 +00:00

huffman.go

http2: number of allocs reduced from 3852 to 31

2021-10-13 15:36:59 +00:00

tables_test.go

…

tables.go

http2/hpack: gofmt -w -s

2017-05-24 14:36:55 +00:00