Matthias Frei a5aa9c730a internal/socket: handle reordering in TestUDP/Messages ...

TestUDP/Messages and TestUDP/Messages-dialed occasionally failed because
the expected messages were not received in a single RecvMsgs call, or
because the messages were received out of order.

Assuming that both messages are returned immediately from a single
RecvMsgs call was a flawed expectation. Fixed by repeatedly invoking
RecvMsgs until all expected messages have been received.

While it certainly seems unusual that packets are reordered on a
loopback device, it does appear to happen occasionally (on linux-mips).
Fixed by sizing receive buffers such that messages in any order can be
received correctly, and by allowing either order for the reassembled
message.

Combine "Messages" and "Messages-dialed" subtests with a simple
table-driven test, to avoid the repetition. The same "Message" and
"Message-dialed".
Finally, make the test failure messages slightly more useful.

Fixes golang/go#49385

Change-Id: I04463c6ffdf4865d2ccfb8662ab4660bda3b3cbf
GitHub-Last-Rev: d9df27b967
GitHub-Pull-Request: golang/net#119
Reviewed-on: https://go-review.googlesource.com/c/net/+/368094
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

2021-12-01 18:16:15 +00:00

..

iana

all: go fmt ./...

2021-02-20 03:31:24 +00:00

socket

internal/socket: handle reordering in TestUDP/Messages

2021-12-01 18:16:15 +00:00

socks

all: fix typos

2019-09-09 00:30:24 +00:00

sockstest

all: use of nettest, remove internal/nettest

2019-03-27 21:43:58 +00:00

timeseries

internal/timeseries: avoid storing numbers as durations

2019-11-09 02:19:31 +00:00