mirror of
https://github.com/golang/net.git
synced 2026-03-31 02:17:08 +09:00
120fc906b3
The priority scheduler allows stream starvation (see golang/go#58804) and is CPU intensive. In addition, the RFC 7540 prioritization scheme it implements was deprecated in RFC 9113 and does not appear to have ever had significant adoption. Add a simple round-robin scheduler and enable it by default. For golang/go#58804 Change-Id: I5c5143aa9bc339fc0894f70d773fa7c0d7d87eef Reviewed-on: https://go-review.googlesource.com/c/net/+/478735 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Damien Neil <dneil@google.com>
66 lines
1.6 KiB
Go
66 lines
1.6 KiB
Go
// Copyright 2023 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package http2
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestRoundRobinScheduler(t *testing.T) {
|
|
const maxFrameSize = 16
|
|
sc := &serverConn{maxFrameSize: maxFrameSize}
|
|
ws := newRoundRobinWriteScheduler()
|
|
streams := make([]*stream, 4)
|
|
for i := range streams {
|
|
streamID := uint32(i) + 1
|
|
streams[i] = &stream{
|
|
id: streamID,
|
|
sc: sc,
|
|
}
|
|
streams[i].flow.add(1 << 20) // arbitrary large value
|
|
ws.OpenStream(streamID, OpenStreamOptions{})
|
|
wr := FrameWriteRequest{
|
|
write: &writeData{
|
|
streamID: streamID,
|
|
p: make([]byte, maxFrameSize*(i+1)),
|
|
endStream: false,
|
|
},
|
|
stream: streams[i],
|
|
}
|
|
ws.Push(wr)
|
|
}
|
|
const controlFrames = 2
|
|
for i := 0; i < controlFrames; i++ {
|
|
ws.Push(makeWriteNonStreamRequest())
|
|
}
|
|
|
|
// We should get the control frames first.
|
|
for i := 0; i < controlFrames; i++ {
|
|
wr, ok := ws.Pop()
|
|
if !ok || wr.StreamID() != 0 {
|
|
t.Fatalf("wr.Pop() = stream %v, %v; want 0, true", wr.StreamID(), ok)
|
|
}
|
|
}
|
|
|
|
// Each stream should write maxFrameSize bytes until it runs out of data.
|
|
// Stream 1 has one frame of data, 2 has two frames, etc.
|
|
want := []uint32{1, 2, 3, 4, 2, 3, 4, 3, 4, 4}
|
|
var got []uint32
|
|
for {
|
|
wr, ok := ws.Pop()
|
|
if !ok {
|
|
break
|
|
}
|
|
if wr.DataSize() != maxFrameSize {
|
|
t.Fatalf("wr.Pop() = %v data bytes, want %v", wr.DataSize(), maxFrameSize)
|
|
}
|
|
got = append(got, wr.StreamID())
|
|
}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("popped streams %v, want %v", got, want)
|
|
}
|
|
}
|