diff --git a/icmp/ipv4.go b/icmp/ipv4.go index 0ad40fef..1ce31f14 100644 --- a/icmp/ipv4.go +++ b/icmp/ipv4.go @@ -9,7 +9,6 @@ import ( "net" "runtime" - "golang.org/x/net/internal/socket" "golang.org/x/net/ipv4" ) @@ -49,12 +48,12 @@ func ParseIPv4Header(b []byte) (*ipv4.Header, error) { } switch runtime.GOOS { case "darwin", "ios": - h.TotalLen = int(socket.NativeEndian.Uint16(b[2:4])) + h.TotalLen = int(binary.NativeEndian.Uint16(b[2:4])) case "freebsd": if freebsdVersion >= 1000000 { h.TotalLen = int(binary.BigEndian.Uint16(b[2:4])) } else { - h.TotalLen = int(socket.NativeEndian.Uint16(b[2:4])) + h.TotalLen = int(binary.NativeEndian.Uint16(b[2:4])) } default: h.TotalLen = int(binary.BigEndian.Uint16(b[2:4])) diff --git a/icmp/ipv4_test.go b/icmp/ipv4_test.go index 479af8e7..2413f1f2 100644 --- a/icmp/ipv4_test.go +++ b/icmp/ipv4_test.go @@ -5,19 +5,17 @@ package icmp import ( - "encoding/binary" "net" "reflect" "runtime" "testing" - "golang.org/x/net/internal/socket" "golang.org/x/net/ipv4" + "golang.org/x/sys/cpu" ) func TestParseIPv4Header(t *testing.T) { - switch socket.NativeEndian { - case binary.LittleEndian: + if !cpu.IsBigEndian { t.Run("LittleEndian", func(t *testing.T) { // TODO(mikio): Add platform dependent wire // header formats when we support new diff --git a/internal/socket/msghdr_solaris_64bit.go b/internal/socket/msghdr_solaris_64bit.go index e212b50f..927ce91a 100644 --- a/internal/socket/msghdr_solaris_64bit.go +++ b/internal/socket/msghdr_solaris_64bit.go @@ -6,7 +6,10 @@ package socket -import "unsafe" +import ( + "encoding/binary" + "unsafe" +) func (h *msghdr) pack(vs []iovec, bs [][]byte, oob []byte, sa []byte) { for i := range vs { @@ -31,5 +34,5 @@ func (h *msghdr) controllen() int { } func (h *msghdr) flags() int { - return int(NativeEndian.Uint32(h.Pad_cgo_2[:])) + return int(binary.NativeEndian.Uint32(h.Pad_cgo_2[:])) } diff --git a/internal/socket/socket.go b/internal/socket/socket.go index dba47bf1..fb7fa1e0 100644 --- a/internal/socket/socket.go +++ b/internal/socket/socket.go @@ -7,6 +7,7 @@ package socket // import "golang.org/x/net/internal/socket" import ( + "encoding/binary" "errors" "net" "runtime" @@ -58,7 +59,7 @@ func (o *Option) GetInt(c *Conn) (int, error) { if o.Len == 1 { return int(b[0]), nil } - return int(NativeEndian.Uint32(b[:4])), nil + return int(binary.NativeEndian.Uint32(b[:4])), nil } // Set writes the option and value to the kernel. @@ -84,7 +85,7 @@ func (o *Option) SetInt(c *Conn, v int) error { b = []byte{byte(v)} } else { var bb [4]byte - NativeEndian.PutUint32(bb[:o.Len], uint32(v)) + binary.NativeEndian.PutUint32(bb[:o.Len], uint32(v)) b = bb[:4] } return o.set(c, b) diff --git a/internal/socket/sys.go b/internal/socket/sys.go deleted file mode 100644 index 4a26af18..00000000 --- a/internal/socket/sys.go +++ /dev/null @@ -1,23 +0,0 @@ -// Copyright 2017 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -package socket - -import ( - "encoding/binary" - "unsafe" -) - -// NativeEndian is the machine native endian implementation of ByteOrder. -var NativeEndian binary.ByteOrder - -func init() { - i := uint32(1) - b := (*[4]byte)(unsafe.Pointer(&i)) - if b[0] == 1 { - NativeEndian = binary.LittleEndian - } else { - NativeEndian = binary.BigEndian - } -} diff --git a/internal/socket/sys_posix.go b/internal/socket/sys_posix.go index 58d86548..84ff2351 100644 --- a/internal/socket/sys_posix.go +++ b/internal/socket/sys_posix.go @@ -36,7 +36,7 @@ func marshalSockaddr(ip net.IP, port int, zone string, b []byte) int { if ip4 := ip.To4(); ip4 != nil { switch runtime.GOOS { case "android", "illumos", "linux", "solaris", "windows": - NativeEndian.PutUint16(b[:2], uint16(sysAF_INET)) + binary.NativeEndian.PutUint16(b[:2], uint16(sysAF_INET)) default: b[0] = sizeofSockaddrInet4 b[1] = sysAF_INET @@ -48,7 +48,7 @@ func marshalSockaddr(ip net.IP, port int, zone string, b []byte) int { if ip6 := ip.To16(); ip6 != nil && ip.To4() == nil { switch runtime.GOOS { case "android", "illumos", "linux", "solaris", "windows": - NativeEndian.PutUint16(b[:2], uint16(sysAF_INET6)) + binary.NativeEndian.PutUint16(b[:2], uint16(sysAF_INET6)) default: b[0] = sizeofSockaddrInet6 b[1] = sysAF_INET6 @@ -56,7 +56,7 @@ func marshalSockaddr(ip net.IP, port int, zone string, b []byte) int { binary.BigEndian.PutUint16(b[2:4], uint16(port)) copy(b[8:24], ip6) if zone != "" { - NativeEndian.PutUint32(b[24:28], uint32(zoneCache.index(zone))) + binary.NativeEndian.PutUint32(b[24:28], uint32(zoneCache.index(zone))) } return sizeofSockaddrInet6 } @@ -70,7 +70,7 @@ func parseInetAddr(b []byte, network string) (net.Addr, error) { var af int switch runtime.GOOS { case "android", "illumos", "linux", "solaris", "windows": - af = int(NativeEndian.Uint16(b[:2])) + af = int(binary.NativeEndian.Uint16(b[:2])) default: af = int(b[1]) } @@ -89,7 +89,7 @@ func parseInetAddr(b []byte, network string) (net.Addr, error) { } ip = make(net.IP, net.IPv6len) copy(ip, b[8:24]) - if id := int(NativeEndian.Uint32(b[24:28])); id > 0 { + if id := int(binary.NativeEndian.Uint32(b[24:28])); id > 0 { zone = zoneCache.name(id) } } diff --git a/ipv4/header.go b/ipv4/header.go index a00a3eaf..ee6edae1 100644 --- a/ipv4/header.go +++ b/ipv4/header.go @@ -9,8 +9,6 @@ import ( "fmt" "net" "runtime" - - "golang.org/x/net/internal/socket" ) const ( @@ -68,12 +66,12 @@ func (h *Header) Marshal() ([]byte, error) { flagsAndFragOff := (h.FragOff & 0x1fff) | int(h.Flags<<13) switch runtime.GOOS { case "darwin", "ios", "dragonfly", "netbsd": - socket.NativeEndian.PutUint16(b[2:4], uint16(h.TotalLen)) - socket.NativeEndian.PutUint16(b[6:8], uint16(flagsAndFragOff)) + binary.NativeEndian.PutUint16(b[2:4], uint16(h.TotalLen)) + binary.NativeEndian.PutUint16(b[6:8], uint16(flagsAndFragOff)) case "freebsd": if freebsdVersion < 1100000 { - socket.NativeEndian.PutUint16(b[2:4], uint16(h.TotalLen)) - socket.NativeEndian.PutUint16(b[6:8], uint16(flagsAndFragOff)) + binary.NativeEndian.PutUint16(b[2:4], uint16(h.TotalLen)) + binary.NativeEndian.PutUint16(b[6:8], uint16(flagsAndFragOff)) } else { binary.BigEndian.PutUint16(b[2:4], uint16(h.TotalLen)) binary.BigEndian.PutUint16(b[6:8], uint16(flagsAndFragOff)) @@ -127,15 +125,15 @@ func (h *Header) Parse(b []byte) error { h.Dst = net.IPv4(b[16], b[17], b[18], b[19]) switch runtime.GOOS { case "darwin", "ios", "dragonfly", "netbsd": - h.TotalLen = int(socket.NativeEndian.Uint16(b[2:4])) + hdrlen - h.FragOff = int(socket.NativeEndian.Uint16(b[6:8])) + h.TotalLen = int(binary.NativeEndian.Uint16(b[2:4])) + hdrlen + h.FragOff = int(binary.NativeEndian.Uint16(b[6:8])) case "freebsd": if freebsdVersion < 1100000 { - h.TotalLen = int(socket.NativeEndian.Uint16(b[2:4])) + h.TotalLen = int(binary.NativeEndian.Uint16(b[2:4])) if freebsdVersion < 1000000 { h.TotalLen += hdrlen } - h.FragOff = int(socket.NativeEndian.Uint16(b[6:8])) + h.FragOff = int(binary.NativeEndian.Uint16(b[6:8])) } else { h.TotalLen = int(binary.BigEndian.Uint16(b[2:4])) h.FragOff = int(binary.BigEndian.Uint16(b[6:8])) diff --git a/ipv4/header_test.go b/ipv4/header_test.go index bbb11b9d..28c5911e 100644 --- a/ipv4/header_test.go +++ b/ipv4/header_test.go @@ -6,14 +6,13 @@ package ipv4 import ( "bytes" - "encoding/binary" "net" "reflect" "runtime" "strings" "testing" - "golang.org/x/net/internal/socket" + "golang.org/x/sys/cpu" ) type headerTest struct { @@ -169,7 +168,7 @@ func TestMarshalHeader(t *testing.T) { } } - if socket.NativeEndian != binary.LittleEndian { + if cpu.IsBigEndian { t.Skip("no test for non-little endian machine yet") } for _, tt := range headerLittleEndianTests { @@ -221,7 +220,7 @@ func TestParseHeader(t *testing.T) { } } - if socket.NativeEndian != binary.LittleEndian { + if cpu.IsBigEndian { t.Skip("no test for big endian machine yet") } for _, tt := range headerLittleEndianTests { diff --git a/ipv6/control_rfc2292_unix.go b/ipv6/control_rfc2292_unix.go index a8f04e7b..e363a3a1 100644 --- a/ipv6/control_rfc2292_unix.go +++ b/ipv6/control_rfc2292_unix.go @@ -7,6 +7,7 @@ package ipv6 import ( + "encoding/binary" "unsafe" "golang.org/x/net/internal/iana" @@ -19,7 +20,7 @@ func marshal2292HopLimit(b []byte, cm *ControlMessage) []byte { m := socket.ControlMessage(b) m.MarshalHeader(iana.ProtocolIPv6, unix.IPV6_2292HOPLIMIT, 4) if cm != nil { - socket.NativeEndian.PutUint32(m.Data(4), uint32(cm.HopLimit)) + binary.NativeEndian.PutUint32(m.Data(4), uint32(cm.HopLimit)) } return m.Next(4) } diff --git a/ipv6/control_rfc3542_unix.go b/ipv6/control_rfc3542_unix.go index 51fbbb1f..95259662 100644 --- a/ipv6/control_rfc3542_unix.go +++ b/ipv6/control_rfc3542_unix.go @@ -7,6 +7,7 @@ package ipv6 import ( + "encoding/binary" "net" "unsafe" @@ -20,26 +21,26 @@ func marshalTrafficClass(b []byte, cm *ControlMessage) []byte { m := socket.ControlMessage(b) m.MarshalHeader(iana.ProtocolIPv6, unix.IPV6_TCLASS, 4) if cm != nil { - socket.NativeEndian.PutUint32(m.Data(4), uint32(cm.TrafficClass)) + binary.NativeEndian.PutUint32(m.Data(4), uint32(cm.TrafficClass)) } return m.Next(4) } func parseTrafficClass(cm *ControlMessage, b []byte) { - cm.TrafficClass = int(socket.NativeEndian.Uint32(b[:4])) + cm.TrafficClass = int(binary.NativeEndian.Uint32(b[:4])) } func marshalHopLimit(b []byte, cm *ControlMessage) []byte { m := socket.ControlMessage(b) m.MarshalHeader(iana.ProtocolIPv6, unix.IPV6_HOPLIMIT, 4) if cm != nil { - socket.NativeEndian.PutUint32(m.Data(4), uint32(cm.HopLimit)) + binary.NativeEndian.PutUint32(m.Data(4), uint32(cm.HopLimit)) } return m.Next(4) } func parseHopLimit(cm *ControlMessage, b []byte) { - cm.HopLimit = int(socket.NativeEndian.Uint32(b[:4])) + cm.HopLimit = int(binary.NativeEndian.Uint32(b[:4])) } func marshalPacketInfo(b []byte, cm *ControlMessage) []byte {