golang.go

mirror of https://github.com/golang/go.git synced 2026-04-01 17:07:17 +09:00

Files

Cuong Manh Le ca5f65d771 cmd/compile: fix generic type handling when crawling inline body

For base generic type that is written to export file, we need to mark
all of its methods, include exported+unexported methods, as reachable,
so they can be available for instantiation if necessary. But markType
only looks for exported methods, thus causing the crash in #49143.

To fix this, we introduce new method p.markGeneric, to mark all methods
of the base generic type.

This issue has happend for a while (maybe since we add generic
import/export during go1.18 cycle), and was un-intentionally "fixed" in
CL 356254, when we agresssively call p.markEmbed(t). CL 357232 fixed
that wrong agressive behavior, thus reproduce the bug on tip.

Fixes #49143

Change-Id: Ie64574a05fffb282e9dcc8739df4378c5b6b0468
Reviewed-on: https://go-review.googlesource.com/c/go/+/358814
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>

2021-10-27 05:33:58 +00:00

abi

cmd/compile: restore tail call for method wrappers

2021-09-17 22:59:44 +00:00

alias3.dir

…

bench

…

chan

…

closure3.dir

…

closure5.dir

…

codegen

test/codegen: updated comparison test to verify on ppc64,ppc64le

2021-10-21 13:05:07 +00:00

ddd2.dir

…

dwarf

…

fixedbugs

cmd/compile: fix generic type handling when crawling inline body

2021-10-27 05:33:58 +00:00

import2.dir

…

import4.dir

…

interface

cmd/compile/internal/types2: avoid "declared but not used" errors for invalid code

2021-09-23 19:41:45 +00:00

intrinsic.dir

…

ken

…

linkname.dir

…

method4.dir

…

oldescape_linkname.dir

…

retjmp.dir

…

runtime

…

stress

…

syntax

…

typeparam

cmd/compile: clean up the switch statements in (*genInst).node()

2021-10-26 20:08:41 +00:00

uintptrescapes.dir

…

64bit.go

…

235.go

…

alg.go

…

alias1.go

…

alias2.go

…

alias3.go

…

alias.go

…

align.go

…

append1.go

…

append.go

…

args.go

…

armimm.go

…

assign1.go

…

assign.go

…

atomicload.go

…

bigalg.go

…

bigmap.go

…

blank1.go

…

blank.go

…

bom.go

…

bombad.go

…

bounds.go

…

cannotassign.go

…

chancap.go

…

chanlinear.go

…

char_lit1.go

…

char_lit.go

…

checkbce.go

…

clearfat.go

…

closedchan.go

…

closure1.go

…

closure2.go

…

closure3.go

…

closure4.go

…

closure5.go

…

closure6.go

…

closure7.go

…

closure.go

…

cmp6.go

…

cmp.go

…

cmplx.go

…

cmplxdivide1.go

…

cmplxdivide.c

…

cmplxdivide.go

…

complit1.go

…

complit.go

…

compos.go

…

const1.go

…

const2.go

…

const3.go

…

const4.go

…

const5.go

…

const6.go

…

const7.go

…

const.go

…

convert1.go

…

convert2.go

…

convert3.go

…

convert4.go

…

convert.go

…

convlit1.go

…

convlit.go

…

convT2X.go

…

copy1.go

…

copy.go

…

crlf.go

…

ddd1.go

…

ddd2.go

…

ddd.go

…

decl.go

…

declbad.go

…

defer.go

…

defererrcheck.go

…

deferfin.go

…

defernil.go

…

deferprint.go

…

deferprint.out

…

devirt.go

[dev.typeparams] cmd/compile: simplify interface conversions

2021-08-09 16:10:20 +00:00

directive.go

…

divide.go

…

divmod.go

…

embedfunc.go

…

embedvers.go

…

empty.go

…

env.go

…

eof1.go

…

eof.go

…

escape2.go

…

escape2n.go

…

escape3.go

…

escape4.go

…

escape5.go

[dev.typeparams] test: rename blank functions

2021-07-28 21:41:07 +00:00

escape_array.go

…

escape_calls.go

…

escape_closure.go

…

escape_field.go

…

escape_goto.go

[dev.typeparams] test: rename blank functions

2021-07-28 21:41:07 +00:00

escape_hash_maphash.go

…

escape_iface.go

…

escape_indir.go

…

escape_level.go

…

escape_map.go

…

escape_param.go

…

escape_runtime_atomic.go

…

escape_selfassign.go

…

escape_slice.go

…

escape_struct_param1.go

…

escape_struct_param2.go

…

escape_struct_return.go

…

escape_sync_atomic.go

…

escape_unsafe.go

…

escape.go

…

fibo.go

…

finprofiled.go

…

float_lit2.go

…

float_lit3.go

…

float_lit.go

…

floatcmp.go

…

for.go

…

func1.go

…

func2.go

…

func3.go

…

func4.go

…

func5.go

…

func6.go

…

func7.go

…

func8.go

…

func.go

…

funcdup2.go

…

funcdup.go

…

fuse.go

…

gc1.go

…

gc2.go

…

gc.go

…

gcgort.go

…

gcstring.go

…

goprint.go

…

goprint.out

…

goto.go

…

heapsampling.go

…

helloworld.go

…

helloworld.out

…

if.go

…

import1.go

…

import2.go

…

import4.go

…

import5.go

…

import6.go

…

import.go

…

index0.go

…

index1.go

…

index2.go

…

index.go

…

indirect1.go

…

indirect.go

…

init1.go

…

init.go

…

initcomma.go

…

initempty.go

…

initexp.go

…

initialize.go

…

initializerr.go

…

initloop.go

…

inline_big.go

…

inline_caller.go

…

inline_callers.go

…

inline_endian.go

test: skip endian inlining test on noopt builder

2021-10-07 00:39:17 +00:00

inline_literal.go

…

inline_math_bits_rotate.go

…

inline_sync.go

…

inline_variadic.go

…

inline.go

cmd/compile: allow inlining labeled for-statement and switch-statement

2021-10-18 15:38:40 +00:00

int_lit.go

…

intcvt.go

…

intrinsic_atomic.go

…

intrinsic.go

…

iota.go

…

label1.go

…

label.go

…

linkmain_run.go

…

linkmain.go

…

linkname2.go

…

linkname.go

…

linkobj.go

…

linkx_run.go

…

linkx.go

…

literal2.go

…

literal.go

…

live1.go

…

live2.go

…

live_regabi.go

test: enable regabi test on arm64

2021-08-20 19:58:13 +00:00

live_syscall.go

…

live.go

[dev.typeparams] cmd/compile: simplify interface conversions

2021-08-09 16:10:20 +00:00

locklinear.go

…

loopbce.go

…

mainsig.go

…

makechan.go

…

makemap.go

…

makenew.go

…

makeslice.go

…

mallocfin.go

…

map1.go

…

map.go

…

mapclear.go

…

maplinear.go

…

mergemul.go

…

method1.go

…

method2.go

…

method3.go

…

method4.go

…

method5.go

…

method6.go

…

method7.go

…

method.go

…

named1.go

…

named.go

…

nil.go

…

nilcheck.go

…

nilptr2.go

…

nilptr3.go

…

nilptr4.go

…

nilptr5_aix.go

…

nilptr5_wasm.go

…

nilptr5.go

…

nilptr_aix.go

…

nilptr.go

…

nosplit.go

…

notinheap2.go

…

notinheap3.go

…

notinheap.go

…

nowritebarrier.go

…

nul1.go

…

opt_branchlikely.go

…

parentype.go

…

peano.go

…

phiopt.go

…

print.go

…

print.out

…

printbig.go

…

printbig.out

…

prove.go

…

range.go

…

README.md

…

recover1.go

…

recover2.go

…

recover3.go

…

recover4.go

…

recover5.go

…

recover.go

…

reflectmethod1.go

…

reflectmethod2.go

…

reflectmethod3.go

…

reflectmethod4.go

…

reflectmethod5.go

…

reflectmethod6.go

…

reflectmethod7.go

all: use reflect.{Pointer,PointerTo}

2021-10-26 14:24:17 +00:00

reflectmethod8.go

…

rename1.go

…

rename.go

…

reorder2.go

…

reorder.go

…

retjmp.go

…

return.go

…

rotate0.go

…

rotate1.go

…

rotate2.go

…

rotate3.go

…

rotate.go

…

run.go

all: use bytes.Cut, strings.Cut

2021-10-06 15:53:04 +00:00

rune.go

…

runtime.go

…

shift1.go

…

shift2.go

…

sieve.go

…

sigchld.go

…

sigchld.out

…

simassign.go

…

sinit_run.go

…

sinit.go

…

sizeof.go

…

slice3.go

…

slice3err.go

…

slicecap.go

…

sliceopt.go

…

solitaire.go

…

stack.go

…

stackobj2.go

…

stackobj3.go

…

stackobj.go

…

strcopy.go

…

strength.go

…

string_lit.go

…

stringrange.go

…

struct0.go

…

switch2.go

…

switch3.go

…

switch4.go

…

switch5.go

…

switch6.go

cmd/compile, types2: better error message for invalid type assertion

2021-10-19 17:01:35 +00:00

switch7.go

…

switch.go

…

tinyfin.go

…

torture.go

…

turing.go

…

typecheck.go

…

typecheckloop.go

…

typeswitch1.go

…

typeswitch2.go

…

typeswitch2b.go

…

typeswitch3.go

…

typeswitch.go

…

uintptrescapes2.go

…

uintptrescapes3.go

…

uintptrescapes.go

…

undef.go

…

unsafebuiltins.go

unsafe: allow unsafe.Slice up to end of address space

2021-10-13 18:15:16 +00:00

used.go

…

utf.go

…

varerr.go

…

varinit.go

…

winbatch.go

…

writebarrier.go

cmd/compile: don't emit write barriers for offsets of global addresses

2021-08-23 19:46:36 +00:00

zerodivide.go

all: use bytes.Cut, strings.Cut

2021-10-06 15:53:04 +00:00

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

To run just tests from specified files in this directory, execute:

../bin/go run run.go -- file1.go file2.go ...

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.