golang.go

mirror of https://github.com/golang/go.git synced 2026-04-01 17:07:17 +09:00

Files

Cuong Manh Le 62654dfd4f cmd/compile: fix wrong typeparams for selector expr with embedded generic type

For selector expression "x.M" where "M" is a promoted method, irgen is using
the type of receiver "x" for determining the typeparams for instantiation.
However, because M is a promoted method, so its associated receiver is
not "x", but "x.T" where "T" is the embedded field of "x". That casues a
mismatch when converting non-shape types arguments.

Fixing it by using the actual receiver which has the method, instead of
using the base receiver.

Fixes #53982

Change-Id: I1836fc422d734df14e9e6664d4bd014503960bfc
Reviewed-on: https://go-review.googlesource.com/c/go/+/419294
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>

2022-08-11 19:05:54 +00:00

abi

cmd/compile: restore tail call for method wrappers

2021-09-17 22:59:44 +00:00

alias3.dir

…

asmhdr.dir

cmd/compile: use exact constant in go_asm.h

2022-01-10 21:27:19 +00:00

bench

test/bench/go1: fix size for RegexpMatchMedium_32

2021-07-18 21:03:43 +00:00

chan

[dev.typeparams] cmd/compile/internal/types2: implement close(ch) where ch is of type parameter type

2021-07-14 23:33:46 +00:00

closure3.dir

cmd/compile/internal/inline: revise closure inl position fix

2021-11-24 15:55:56 +00:00

closure5.dir

test: use dot-relative imports where appropriate

2022-03-24 02:14:15 +00:00

codegen

cmd/compile/internal/ssa: optimize ARM64 code with TST

2022-08-10 02:13:53 +00:00

ddd2.dir

…

dwarf

…

fixedbugs

cmd/compile: fix wrong typeparams for selector expr with embedded generic type

2022-08-11 19:05:54 +00:00

import2.dir

…

import4.dir

…

interface

cmd/compile: require -p flag

2022-03-09 21:31:58 +00:00

intrinsic.dir

…

ken

test/ken/slicearray.go: correct type width in comment

2021-12-05 12:50:44 +00:00

linkname.dir

test: compile source files as if from "test" module

2022-03-24 17:50:47 +00:00

method4.dir

…

retjmp.dir

cmd/internal/obj: fix tail call in non-zero frame leaf function on MIPS and S390X

2021-12-13 22:42:08 +00:00

runtime

…

stress

…

syntax

cmd/compile/internal/syntax: better errors for syntax errors in lists

2022-03-31 00:26:58 +00:00

typeparam

test: test method expressions promoted to derived types

2022-08-09 16:42:12 +00:00

uintptrescapes.dir

…

64bit.go

…

235.go

…

alg.go

…

alias1.go

…

alias2.go

cmd/compile: match Go 1.17 compiler error messages more closely

2021-11-12 23:07:01 +00:00

alias3.go

…

alias.go

…

align.go

…

append1.go

cmd/compile: match Go 1.17 compiler error messages more closely

2021-11-12 23:07:01 +00:00

append.go

…

args.go

…

armimm.go

…

asmhdr.go

cmd/compile: emit sensible go_asm.h consts for big ints

2021-10-30 18:30:05 +00:00

assign1.go

…

assign.go

…

atomicload.go

…

bigalg.go

…

bigmap.go

…

blank1.go

…

blank.go

…

bom.go

…

bombad.go

…

bounds.go

…

cannotassign.go

…

chancap.go

…

chanlinear.go

…

char_lit1.go

…

char_lit.go

…

checkbce.go

…

clearfat.go

…

closedchan.go

…

closure1.go

…

closure2.go

…

closure3.go

…

closure4.go

…

closure5.go

…

closure6.go

…

closure7.go

…

closure.go

…

cmp6.go

…

cmp.go

…

cmplx.go

…

cmplxdivide1.go

…

cmplxdivide.c

…

cmplxdivide.go

…

complit1.go

test: fix error check messages for 2 types2 tests

2021-06-02 05:14:45 +00:00

complit.go

…

compos.go

…

const1.go

…

const2.go

…

const3.go

…

const4.go

…

const5.go

…

const6.go

…

const7.go

cmd/compile: require -p flag

2022-03-09 21:31:58 +00:00

const8.go

test: add more tests for const decls with ommitted RHS expressions

2022-06-28 18:11:31 +00:00

const.go

…

convert1.go

…

convert2.go

…

convert3.go

…

convert4.go

…

convert.go

…

convlit1.go

…

convlit.go

…

convT2X.go

…

copy1.go

…

copy.go

…

crlf.go

…

ddd1.go

cmd/compile: match Go 1.17 compiler error messages more closely

2021-11-12 23:07:01 +00:00

ddd2.go

…

ddd.go

…

decl.go

…

declbad.go

cmd/compile: rewrite a, b = f() to use temporaries when type not identical

2021-06-14 07:12:37 +00:00

defer.go

…

defererrcheck.go

…

deferfin.go

…

defernil.go

…

deferprint.go

…

deferprint.out

…

devirt.go

[dev.typeparams] cmd/compile: simplify interface conversions

2021-08-09 16:10:20 +00:00

directive2.go

test: re-enable a bunch of tests with types2

2021-12-03 16:24:32 +00:00

directive.go

test: re-enable a bunch of tests with types2

2021-12-03 16:24:32 +00:00

divide.go

…

divmod.go

…

embedfunc.go

…

embedvers.go

…

empty.go

…

env.go

…

eof1.go

…

eof.go

…

escape2.go

[dev.typeparams] cmd/compile: move call logic from order.go to escape

2021-06-23 16:48:12 +00:00

escape2n.go

[dev.typeparams] cmd/compile: move call logic from order.go to escape

2021-06-23 16:48:12 +00:00

escape3.go

…

escape4.go

…

escape5.go

[dev.typeparams] test: rename blank functions

2021-07-28 21:41:07 +00:00

escape_array.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_calls.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_closure.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_field.go

…

escape_goto.go

[dev.typeparams] test: rename blank functions

2021-07-28 21:41:07 +00:00

escape_hash_maphash.go

…

escape_iface_nounified.go

[dev.unified] test: break escape_iface.go into unified/nounified variants

2022-06-30 18:41:26 +00:00

escape_iface_unified.go

[dev.unified] cmd/compile/internal/noder: implicit conversions for multi-valued expressions

2022-06-30 18:42:24 +00:00

escape_iface.go

[dev.unified] test: break escape_iface.go into unified/nounified variants

2022-06-30 18:41:26 +00:00

escape_indir.go

…

escape_level.go

…

escape_map.go

…

escape_param.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_runtime_atomic.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_selfassign.go

…

escape_slice.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_struct_param1.go

…

escape_struct_param2.go

…

escape_struct_return.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape_sync_atomic.go

…

escape_unsafe.go

[dev.typeparams] cmd/compile: simplify ~r/~b naming

2021-05-26 23:50:32 +00:00

escape.go

…

fibo.go

…

finprofiled.go

…

float_lit2.go

…

float_lit3.go

test: re-enable a bunch of tests with types2

2021-12-03 16:24:32 +00:00

float_lit.go

…

floatcmp.go

…

for.go

…

func1.go

…

func2.go

…

func3.go

…

func4.go

…

func5.go

…

func6.go

…

func7.go

…

func8.go

…

func.go

…

funcdup2.go

…

funcdup.go

…

fuse.go

test: do not run fuse test in noopt mode

2021-04-28 15:55:10 +00:00

gc1.go

…

gc2.go

…

gc.go

…

gcgort.go

…

gcstring.go

…

goprint.go

…

goprint.out

…

goto.go

…

heapsampling.go

test/heapsampling.go: slow down allocation rate and reduce iterations

2022-05-27 21:36:06 +00:00

helloworld.go

…

helloworld.out

…

if.go

…

import1.go

test: re-enable most go/tests that were disabled because of types2 differences

2022-01-11 02:26:58 +00:00

import2.go

…

import4.go

…

import5.go

…

import6.go

test: re-enable most go/tests that were disabled because of types2 differences

2022-01-11 02:26:58 +00:00

import.go

…

index0.go

…

index1.go

…

index2.go

…

index.go

…

indirect1.go

…

indirect.go

…

init1.go

…

init.go

…

initcomma.go

…

initempty.go

…

initexp.go

…

initialize.go

…

initializerr.go

test: re-enable most go/tests that were disabled because of types2 differences

2022-01-11 02:26:58 +00:00

initloop.go

…

inline_big.go

[dev.typeparams] cmd/compile/internal/inline: refactor mkinlcall

2021-05-27 23:40:56 +00:00

inline_caller.go

…

inline_callers.go

…

inline_endian.go

test: skip endian inlining test on noopt builder

2021-10-07 00:39:17 +00:00

inline_literal.go

…

inline_math_bits_rotate.go

…

inline_nounified.go

[dev.unified] test: extract different inline test between unified and non-unified

2022-06-15 21:22:56 +00:00

inline_sync.go

…

inline_unified.go

[dev.unified] test: extract different inline test between unified and non-unified

2022-06-15 21:22:56 +00:00

inline_variadic.go

[dev.typeparams] cmd/compile: simplify inlining variadic calls

2021-05-26 23:50:45 +00:00

inline.go

[dev.unified] test: extract different inline test between unified and non-unified

2022-06-15 21:22:56 +00:00

int_lit.go

…

intcvt.go

…

intrinsic_atomic.go

misc, test: fix test error for loong64

2022-05-20 16:16:37 +00:00

intrinsic.go

…

iota.go

…

label1.go

…

label.go

…

linkmain_run.go

cmd/compile: require -p flag

2022-03-09 21:31:58 +00:00

linkmain.go

…

linkname3.go

test: re-enable a bunch of tests with types2

2021-12-03 16:24:32 +00:00

linkname.go

…

linkobj.go

cmd/compile: require -p flag

2022-03-09 21:31:58 +00:00

linkx_run.go

…

linkx.go

…

literal2.go

…

literal.go

…

live1.go

…

live2.go

…

live_regabi.go

[dev.unified] test: relax live_regabi.go

2022-06-30 18:41:17 +00:00

live_uintptrkeepalive.go

all: fix spelling

2022-05-17 19:51:29 +00:00

live.go

test: relax live.go for GOEXPERIMENT=unified

2022-08-10 18:52:08 +00:00

loopbce.go

cmd/compile: rework induction variable detector

2022-07-06 17:00:37 +00:00

mainsig.go

…

makechan.go

…

makemap.go

…

makenew.go

…

makeslice.go

…

mallocfin.go

…

map1.go

…

map.go

…

mapclear.go

…

maplinear.go

…

maymorestack.go

cmd/{asm,compile,internal/obj}: add "maymorestack" support

2021-11-05 00:52:06 +00:00

mergemul.go

…

method1.go

…

method2.go

go/types, types2: better error message when using *interface instead of interface

2022-01-10 22:48:40 +00:00

method3.go

…

method4.go

…

method5.go

…

method6.go

…

method7.go

…

method.go

…

named1.go

…

named.go

…

nil.go

…

nilcheck.go

[dev.unified] test: tweak nilcheck test

2022-06-30 18:41:59 +00:00

nilptr2.go

…

nilptr3.go

…

nilptr4.go

…

nilptr5_aix.go

…

nilptr5_wasm.go

…

nilptr5.go

…

nilptr_aix.go

…

nilptr.go

…

nosplit.go

misc, test: fix test error for loong64

2022-05-20 16:16:37 +00:00

notinheap2.go

…

notinheap3.go

…

notinheap.go

…

nowritebarrier.go

…

nul1.go

…

opt_branchlikely.go

…

parentype.go

…

peano.go

…

phiopt.go

…

print.go

…

print.out

…

printbig.go

…

printbig.out

…

prove_constant_folding.go

cmd/compile: fold constants found by prove

2022-05-04 20:30:17 +00:00

prove.go

cmd/compile: teach prove about and operation

2022-05-08 20:10:06 +00:00

range.go

…

README.md

…

recover1.go

…

recover2.go

…

recover3.go

…

recover4.go

test/recover4.go: use mprotect to create a hole instead of munmap

2021-11-12 16:58:34 +00:00

recover5.go

…

recover.go

…

reflectmethod1.go

…

reflectmethod2.go

…

reflectmethod3.go

…

reflectmethod4.go

…

reflectmethod5.go

…

reflectmethod6.go

…

reflectmethod7.go

all: use reflect.{Pointer,PointerTo}

2021-10-26 14:24:17 +00:00

reflectmethod8.go

[dev.typeparams] cmd/compile: fix missing condition in usemethod

2021-07-22 17:48:41 +00:00

rename1.go

…

rename.go

…

reorder2.go

…

reorder.go

…

retjmp.go

…

return.go

…

rotate0.go

…

rotate1.go

…

rotate2.go

…

rotate3.go

…

rotate.go

…

run.go

test: more robust detection of GOEXPERIMENT=unified

2022-08-10 18:52:00 +00:00

rune.go

…

runtime.go

…

shift1.go

test: re-enable a bunch of tests with types2

2021-12-03 16:24:32 +00:00

shift2.go

…

shift3.go

cmd/compile: adjust types2 shift check to match go/types (cleanup)

2022-04-07 17:19:55 +00:00

sieve.go

…

sigchld.go

…

sigchld.out

…

simassign.go

…

sinit_run.go

cmd/compile: require -p flag

2022-03-09 21:31:58 +00:00

sinit.go

…

sizeof.go

…

slice3.go

…

slice3err.go

…

slicecap.go

…

sliceopt.go

…

solitaire.go

…

stack.go

…

stackobj2.go

…

stackobj3.go

…

stackobj.go

…

strcopy.go

…

strength.go

…

string_lit.go

…

stringrange.go

…

struct0.go

…

switch2.go

…

switch3.go

…

switch4.go

…

switch5.go

…

switch6.go

cmd/compile, types2: better error message for invalid type assertion

2021-10-19 17:01:35 +00:00

switch7.go

…

switch.go

[dev.unified] test: add switch test case for tricky nil handling

2022-07-19 23:30:49 +00:00

tinyfin.go

…

torture.go

…

turing.go

…

typecheck.go

test: re-enable most go/tests that were disabled because of types2 differences

2022-01-11 02:26:58 +00:00

typecheckloop.go

…

typeswitch1.go

…

typeswitch2.go

…

typeswitch2b.go

…

typeswitch3.go

cmd/compile/internal/types2: better error for type assertion/switch on type parameter value

2021-11-12 22:20:51 +00:00

typeswitch.go

…

uintptrescapes2.go

[dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers

2021-06-24 18:24:24 +00:00

uintptrescapes3.go

…

uintptrescapes.go

…

uintptrkeepalive.go

cmd/compile: add //go:uintptrkeepalive

2022-04-21 18:06:38 +00:00

undef.go

…

unsafebuiltins.go

unsafe: allow unsafe.Slice up to end of address space

2021-10-13 18:15:16 +00:00

used.go

…

utf.go

…

varerr.go

…

varinit.go

…

winbatch.go

…

writebarrier.go

cmd/compile: don't emit write barriers for offsets of global addresses

2021-08-23 19:46:36 +00:00

zerodivide.go

all: use bytes.Cut, strings.Cut

2021-10-06 15:53:04 +00:00

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

To run just tests from specified files in this directory, execute:

../bin/go run run.go -- file1.go file2.go ...

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.