mirror of
https://github.com/golang/go.git
synced 2026-04-02 01:10:27 +09:00
9ce4f3876e
The current bloop pass implementation skips blank nodes silently. This CL makes it aware of that and keep them alive in temps. Fixes #77654. Change-Id: Iaffa5194ba1f0fe8d7c80a4c8e5c9a65a47bf534 Reviewed-on: https://go-review.googlesource.com/c/go/+/754920 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@golang.org>
73 lines
2.7 KiB
Go
73 lines
2.7 KiB
Go
// errorcheck -0 -m=2
|
|
|
|
// Copyright 2025 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test keeping statements results in testing.B.Loop alive.
|
|
// See issue #61515, #73137.
|
|
|
|
package foo
|
|
|
|
import "testing"
|
|
|
|
func caninline(x int) int { // ERROR "can inline caninline"
|
|
return x
|
|
}
|
|
|
|
func caninlineMulti(x int) (int, int) { // ERROR "can inline caninlineMulti"
|
|
return x, x
|
|
}
|
|
|
|
var something int
|
|
|
|
func caninlineNoRet(x int) { // ERROR "can inline caninlineNoRet"
|
|
something = x
|
|
}
|
|
|
|
func caninlineVariadic(x ...int) { // ERROR "can inline caninlineVariadic" "x does not escape"
|
|
something = x[0]
|
|
}
|
|
|
|
func receiver(f func()) { // ERROR "can inline receiver" "f does not escape"
|
|
f()
|
|
}
|
|
|
|
func argument() {} // ERROR "can inline argument"
|
|
|
|
func test(b *testing.B, localsink, cond int) { // ERROR ".*"
|
|
for i := 0; i < b.N; i++ {
|
|
caninline(1) // ERROR "inlining call to caninline"
|
|
}
|
|
somethingptr := &something
|
|
for b.Loop() { // ERROR "inlining call to testing\.\(\*B\)\.Loop"
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive"
|
|
caninlineNoRet(1) // ERROR "inlining call to caninlineNoRet" "function arg will be kept alive"
|
|
caninlineVariadic(1) // ERROR "inlining call to caninlineVariadic" "function arg will be kept alive" ".* does not escape"
|
|
caninlineVariadic(localsink) // ERROR "inlining call to caninlineVariadic" "localsink will be kept alive" ".* does not escape"
|
|
localsink = caninline(1) // ERROR "inlining call to caninline" "localsink will be kept alive"
|
|
localsink += 5 // ERROR "localsink will be kept alive"
|
|
localsink, cond = 1, 2 // ERROR "localsink will be kept alive" "cond will be kept alive"
|
|
*somethingptr = 1 // ERROR "dereference will be kept alive"
|
|
if cond > 0 {
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive"
|
|
}
|
|
switch cond {
|
|
case 2:
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive"
|
|
}
|
|
{
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive"
|
|
}
|
|
|
|
_ = caninline(1) // ERROR "inlining call to caninline" ".*autotmp.* will be kept alive"
|
|
|
|
// An assign list stmt with a single rhs expression returning multiple values via a tuple.
|
|
_, _ = caninlineMulti(1) // ERROR "inlining call to caninlineMulti" ".*autotmp.* will be kept alive"
|
|
// An assign list stmt with multiple rhs expressions.
|
|
_, _ = caninline(1), caninline(2) // ERROR "inlining call to caninline" ".*autotmp.* will be kept alive"
|
|
|
|
receiver(argument) // ERROR inlining call to receiver" "function arg will be kept alive"
|
|
}
|
|
}
|