7 Commits

Author SHA1 Message Date
Cuong Manh Le
1f8aff4386 simd/archsimd: mark pa* unsafe helpers as nocheckptr
Despite the cast from smaller to bigger slice, the elements after the
input slice length are not actually read. Thus they should have
nocheckptr annotation to make checkptr happy.

Fixes #78413

Change-Id: I3e27eab8a69b37bb11632b130a87e6625e06e8ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/761120
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
2026-03-30 21:19:14 -07:00
Cherry Mui
8411ab9d3d Revert "test/simd: add test for issue 77582"
This reverts CL 748760.

Reason for revert:
1. the fix in CL 745460 is not really correct.
2. this test doesn't actually reproduce the failure. (It needs to
   actually use the result, instead of assigning to _.)

Change-Id: Ifb3da8954c5e8774ac000ee3bbf92e5813705dd6
Reviewed-on: https://go-review.googlesource.com/c/go/+/749240
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Cherry Mui <cherryyz@google.com>
2026-02-25 14:08:02 -08:00
Eyalcfish
78da9242cd test/simd: add test for issue 77582
This addresses post-merge feedback from Cherry regarding CL 745460.

Updates #77582

Change-Id: I1165b8f499d2381b3d45e4a14f9d052d947b33c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/748760
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
2026-02-25 11:19:51 -08:00
David Chase
144cf17d2c [dev.simd] simd, cmd/compile: move "simd" to "simd/archsimd"
Also removes a few leftover TODOs and scraps of commented-out code
from simd development.

Updated etetest.sh to make it behave whether amd64 implies the
experiment, or not.

Fixes #76473.

Change-Id: I6d9792214d7f514cb90c21b101dbf7d07c1d0e55
Reviewed-on: https://go-review.googlesource.com/c/go/+/728220
TryBot-Bypass: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2025-12-08 13:57:44 -08:00
Junyang Shao
63a09d6d3d [dev.simd] cmd/compile: fix SIMD const rematerialization condition
This CL fixes a condition for the previous fix CL 704056.

Change-Id: I1f1f8c6f72870403cb3dff14755c43385dc0c933
Reviewed-on: https://go-review.googlesource.com/c/go/+/705499
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2025-09-22 16:19:02 -07:00
Junyang Shao
d9751166a6 [dev.simd] cmd/compile: handle rematerialized op for incompatible reg constraint
This CL fixes an issue raised by contributor dominikh@.

Change-Id: I941b330a6ba6f6c120c69951ddd24933f2f0b3ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/704056
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
2025-09-18 11:06:57 -07:00
Cherry Mui
0e590a505d [dev.simd] cmd/compile: use the right type for spill slot
Currently, when shuffling registers, if we need to spill a
register, we always create a spill slot of type int64. The type
doesn't actually matter, as long as it is wide enough to hold the
registers. This is no longer true with SIMD registers, which could
be wider than a int64. Create the slot with the proper type
instead.

Change-Id: I85c82e2532001bfdefe98c9446f2dd18583d49b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/704055
TryBot-Bypass: Cherry Mui <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
2025-09-16 07:21:17 -07:00