github/golang.go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-04-02 01:10:27 +09:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: add I64Sub constant folding rule for wasm

Browse Source 
Add the missing I64Sub constant folding rule to the wasm backend.
Every other wasm arithmetic operation (I64Add, I64Mul, I64And, I64Or,
I64Xor, I64Shl, I64ShrU, I64ShrS) already had a post-lowering
constant folding rule, but I64Sub was missing.

While the generic SSA pass folds Sub64(Const64, Const64) before
lowering, this rule ensures consistency and handles any edge cases
where later wasm-specific passes produce I64Sub with two constant
operands.

Cq-Include-Trybots: luci.golang.try:gotip-wasip1-wasm_wasmtime,gotip-wasip1-wasm_wazero
Change-Id: Ie8bc044dd300dcc6d077feec34f9a65f4a310b13
Reviewed-on: https://go-review.googlesource.com/c/go/+/751441
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: David Chase <drchase@google.com>
Commit-Queue: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
George Adams
2026-03-04 13:45:31 +00:00
committed by Gopher Robot
parent 0359353574
commit b764d47e4d
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/cmd/compile/internal/ssa/_gen/Wasm.rules
View File

@@ -374,6 +374,7 @@
// --- Optimizations ---
(I64Add (I64Const [x]) (I64Const [y])) => (I64Const [x + y])
(I64Sub (I64Const [x]) (I64Const [y])) => (I64Const [x - y])
(I64Mul (I64Const [x]) (I64Const [y])) => (I64Const [x * y])
(I64And (I64Const [x]) (I64Const [y])) => (I64Const [x & y])
(I64Or (I64Const [x]) (I64Const [y])) => (I64Const [x | y])

22
src/cmd/compile/internal/ssa/rewriteWasm.go
View File

@@ -656,6 +656,8 @@ func rewriteValueWasm(v *Value) bool {
return rewriteValueWasm_OpWasmI64Store32(v)
case OpWasmI64Store8:
return rewriteValueWasm_OpWasmI64Store8(v)
case OpWasmI64Sub:
return rewriteValueWasm_OpWasmI64Sub(v)
case OpWasmI64Xor:
return rewriteValueWasm_OpWasmI64Xor(v)
case OpXor16:
@@ -4746,6 +4748,26 @@ func rewriteValueWasm_OpWasmI64Store8(v *Value) bool {
}
return false
}
func rewriteValueWasm_OpWasmI64Sub(v *Value) bool {
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (I64Sub (I64Const [x]) (I64Const [y]))
// result: (I64Const [x - y])
for {
if v_0.Op != OpWasmI64Const {
break
}
x := auxIntToInt64(v_0.AuxInt)
if v_1.Op != OpWasmI64Const {
break
}
y := auxIntToInt64(v_1.AuxInt)
v.reset(OpWasmI64Const)
v.AuxInt = int64ToAuxInt(x - y)
return true
}
return false
}
func rewriteValueWasm_OpWasmI64Xor(v *Value) bool {
v_1 := v.Args[1]
v_0 := v.Args[0]