github/golang.go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-04-04 10:20:00 +09:00
Code Issues Packages Projects Releases Wiki Activity

bytes: remove unused indexBytePortable

Browse Source 
The function "indexBytePortable" is no longer in use, and we have an
identical one in "internal/bytealg".

Remove this function and related tests.

Change-Id: I018a92902f881836699c6a90511359d8bfa16f80
GitHub-Last-Rev: d9c8917253
GitHub-Pull-Request: golang/go#78029
Reviewed-on: https://go-review.googlesource.com/c/go/+/753080
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Freeman <markfreeman@google.com>
This commit is contained in:
apocelipes
2026-03-09 17:32:42 +00:00
committed by Gopher Robot
parent e22dc6c866
commit 935ba2e486
4 changed files with 21 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/bytes/bytes.go
View File

@@ -98,15 +98,6 @@ func IndexByte(b []byte, c byte) int {
return bytealg.IndexByte(b, c)
}
func indexBytePortable(s []byte, c byte) int {
for i, b := range s {
if b == c {
return i
}
}
return -1
}
// LastIndex returns the index of the last instance of sep in s, or -1 if sep is not present in s.
func LastIndex(s, sep []byte) int {
n := len(sep)

16
src/bytes/bytes_test.go
View File

@@ -323,10 +323,6 @@ func TestIndexByte(t *testing.T) {
if pos != tt.i {
t.Errorf(`IndexByte(%q, '%c') = %v`, tt.a, b, pos)
}
posp := IndexBytePortable(a, b)
if posp != tt.i {
t.Errorf(`indexBytePortable(%q, '%c') = %v`, tt.a, b, posp)
}
}
}
@@ -617,8 +613,18 @@ func BenchmarkIndexByte(b *testing.B) {
benchBytes(b, indexSizes, bmIndexByte(IndexByte))
}
// indexBytePortable use as the baseline for performance comparisons.
func indexBytePortable(s []byte, c byte) int {
for i, b := range s {
if b == c {
return i
}
}
return -1
}
func BenchmarkIndexBytePortable(b *testing.B) {
benchBytes(b, indexSizes, bmIndexByte(IndexBytePortable))
benchBytes(b, indexSizes, bmIndexByte(indexBytePortable))
}
func bmIndexByte(index func([]byte, byte) int) func(b *testing.B, n int) {

8
src/bytes/export_test.go
View File

@@ -1,8 +0,0 @@
// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package bytes
// Export func for testing
var IndexBytePortable = indexBytePortable

20
src/cmd/go/testdata/script/list_test.txt vendored
View File

@@ -4,18 +4,18 @@
[compiler:gccgo] skip 'gccgo does not have standard packages'
go list -test -deps bytes
stdout '^bytes.test$' # test main
stdout '^bytes$' # real bytes
stdout '^bytes \[bytes.test\]$' # test copy of bytes
stdout 'testing \[bytes.test\]$' # test copy of testing
go list -test -deps strings
stdout '^strings.test$' # test main
stdout '^strings$' # real strings
stdout '^strings \[strings.test\]$' # test copy of strings
stdout 'testing \[strings.test\]$' # test copy of testing
! stdout ^testing$ # should not have real testing
go list -test bytes
stdout '^bytes.test$' # test main
stdout '^bytes$' # real bytes
stdout '^bytes \[bytes.test\]$' # test copy of bytes
! stdout '^testing \[bytes.test\]$' # should not have test copy of testing
go list -test strings
stdout '^strings.test$' # test main
stdout '^strings$' # real strings
stdout '^strings \[strings.test\]$' # test copy of strings
! stdout '^testing \[strings.test\]$' # should not have test copy of testing
! stdout '^testing$' # should not have real testing
go list -test cmd/buildid cmd/gofmt