github/golang.go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-04-03 09:49:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

net/http/internal/http2: deflake TestServer_Rejects_Too_Many_Streams

Browse Source 
This test contains a race condition in the server handler:

	inHandler <- streamID
	<-leaveHandler

We assume that all requests queue reading from leaveHandler in order,
but it is possible for the second request (stream id 3) to arrive at
leaveHandler before the first (stream id 1).

We could fix the race with a judicious synctest.Wait, but rewrite
the test to use serverHandlerCall to manipulate server handlers,
which permits us to precisely pick which request to unblock.

Fixes #78117

Change-Id: Icd393c81e019a0b5176976a6b50145a26a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/755320
Reviewed-by: Nicholas Husin <nsh@golang.org>
Reviewed-by: Nicholas Husin <husin@google.com>
Auto-Submit: Nicholas Husin <husin@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Damien Neil
2026-03-13 14:43:22 -07:00
committed by Gopher Robot
parent 6614616b75
commit 48bbe7996d
1 changed files with 7 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/net/http/internal/http2/server_test.go
View File

@@ -2386,18 +2386,7 @@ func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
synctestTest(t, testServer_Rejects_Too_Many_Streams)
}
func testServer_Rejects_Too_Many_Streams(t testing.TB) {
inHandler := make(chan uint32)
leaveHandler := make(chan bool)
st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
var streamID uint32
if _, err := fmt.Sscanf(r.URL.Path, "/%d", &streamID); err != nil {
t.Errorf("parsing %q: %v", r.URL.Path, err)
}
inHandler <- streamID
<-leaveHandler
})
defer st.Close()
st := newServerTester(t, nil)
st.greet()
nextStreamID := uint32(1)
streamID := func() uint32 {
@@ -2414,15 +2403,11 @@ func testServer_Rejects_Too_Many_Streams(t testing.TB) {
EndHeaders: true,
})
}
var calls []*serverHandlerCall
for i := 0; i < DefaultMaxStreams; i++ {
sendReq(streamID())
<-inHandler
calls = append(calls, st.nextHandlerCall())
}
defer func() {
for i := 0; i < DefaultMaxStreams; i++ {
leaveHandler <- true
}
}()
// And this one should cross the limit:
// (It's also sent as a CONTINUATION, to verify we still track the decoder context,
@@ -2443,7 +2428,7 @@ func testServer_Rejects_Too_Many_Streams(t testing.TB) {
st.wantRSTStream(rejectID, ErrCodeProtocol)
// But let a handler finish:
leaveHandler <- true
calls[0].exit()
st.sync()
st.wantHeaders(wantHeader{
streamID: 1,
@@ -2453,8 +2438,9 @@ func testServer_Rejects_Too_Many_Streams(t testing.TB) {
// And now another stream should be able to start:
goodID := streamID()
sendReq(goodID)
if got := <-inHandler; got != goodID {
t.Errorf("Got stream %d; want %d", got, goodID)
call := st.nextHandlerCall()
if got, want := call.req.URL.Path, fmt.Sprintf("/%d", goodID); got != want {
t.Errorf("Got request for %q, want %q", got, want)
}
}