mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-01 00:37:42 +09:00
db7eb4d51b
Use shared repo permission resolution for Actions task users in issue label remove and clear paths, and add a regression test for deleting issue labels with a Gitea Actions token. This fixes issue label deletion when the request is authenticated with a Gitea Actions token. Fixes #37011 The bug was that the delete path re-resolved repository permissions using the normal user permission helper, which does not handle Actions task users. As a result, `DELETE /api/v1/repos/{owner}/{repo}/issues/{index}/labels/{id}` could return `500` for Actions tokens even though label listing and label addition worked. --------- Co-authored-by: Codex <codex@openai.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
41 lines
1.0 KiB
Go
41 lines
1.0 KiB
Go
// Copyright 2022 The Gitea Authors.
|
|
// All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package pull
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
unit_model "code.gitea.io/gitea/models/unit"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
)
|
|
|
|
var ErrUserHasNoPermissionForAction = errors.New("user not allowed to do this action")
|
|
|
|
// SetAllowEdits allow edits from maintainers to PRs
|
|
func SetAllowEdits(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest, allow bool) error {
|
|
if doer == nil || !pr.Issue.IsPoster(doer.ID) {
|
|
return ErrUserHasNoPermissionForAction
|
|
}
|
|
|
|
if err := pr.LoadHeadRepo(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
permission, err := access_model.GetDoerRepoPermission(ctx, pr.HeadRepo, doer)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if !permission.CanWrite(unit_model.TypeCode) {
|
|
return ErrUserHasNoPermissionForAction
|
|
}
|
|
|
|
pr.AllowMaintainerEdit = allow
|
|
return issues_model.UpdateAllowEdits(ctx, pr)
|
|
}
|